[High Contrast Mode] Loading components and beacons #8215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- diff gets really annoying otherwise, so get this out of the way + remove fragment usage
- for both native and indeterminate loaders + increase thickness of smallest size for all high contrast modes + fix border radius overflow for absolutely positioned panels (a lot more noticeable with increased border size)
+ increase contrast of mono bar shades note: hide whitespicc diffs here to make review easier
…l high contrast modes leavingt the colors mostly intact, not sure there's a whole lot we can do here
- by just... ignoring it lol - colors are likely monochrome enough to be safe for most high contrast themes, and since these are non-interactive loading states, they don't *need* to be as high contrast
- also just by ignoring + indentation
cee-chen
force-pushed
the
high-contrast-mode-5
branch
from
425e20c to
f981d97
Compare
mgadewoll
reviewed
Dec 10, 2024
|
Preview staging links for this PR:
|
💚 Build Succeeded
History
|
mgadewoll
approved these changes
Dec 11, 2024
|
Thanks a million as always for your super thoughtful reviews Lene! They always improve the end-result so much! ✨ |
cee-chen
added a commit
that referenced
this pull request
Dec 12, 2024
mgadewoll
pushed a commit
to mgadewoll/eui
that referenced
this pull request
Mar 14, 2025
12 tasks
mgadewoll
pushed a commit
to mgadewoll/eui
that referenced
this pull request
Mar 18, 2025
mgadewoll
pushed a commit
to mgadewoll/eui
that referenced
this pull request
Mar 18, 2025
mgadewoll
pushed a commit
to mgadewoll/eui
that referenced
this pull request
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Note
This PR merges into a feature branch.
Primarily fixes component rendering in Windows high contrast mode, mostly with
forced-color-adjust: none(since these are very graphic-heavy components).EuiProgress does have some tricky logic/ternaries, so I recommend reviewing that one by commit.
QA
General checklist
- [ ] Checked for accessibility including keyboard-only and screenreader modes- [ ] Added or updated jest and cypress tests