Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Visual Refresh] Design changes #8111

Merged

Conversation

mgadewoll
Copy link
Contributor

@mgadewoll mgadewoll commented Nov 1, 2024

Summary

Important

This PR merges into a feature branch.

This PR contains latest design updates to the new theme.

Changes

🎨 Changes added reflect expected design changes mentioned here.

  • updates lightestShade token value for light mode to shade15
  • adds "flags" key on themes for theme-specific global settings that can be used as feature flag in-code usages
  • updates token mappings (specifically for input borders)
  • adds floating boarders to more components (popover, tooltip, panels, modals, overlay flyouts)
  • refactors how the popover arrow is built (to simplifying styles and ensure we can apply a border)

QA

@mgadewoll mgadewoll changed the title Eui theme/design changes [Visual Refresh] Design changes Nov 1, 2024
refactor: add button group focus token
- updates form borders
opinionated: refactors how popover arrows are built; uses element over borders to ensure we can add borders and reduces needed css
@mgadewoll mgadewoll force-pushed the eui-theme/design-changes branch from 3a7fb28 to 594ab06 Compare November 1, 2024 10:50
@mgadewoll mgadewoll marked this pull request as ready for review November 4, 2024 08:11
@mgadewoll mgadewoll requested a review from a team as a code owner November 4, 2024 08:11
@mgadewoll mgadewoll requested a review from tkajtoch November 4, 2024 10:46
@mgadewoll mgadewoll force-pushed the eui-theme/design-changes branch from 0c33c1e to b4fd0b9 Compare November 4, 2024 11:06
-adds flaoting boarder on dark mode only to prevent layout changes for child components due to transparent border on light mode
@kibanamachine
Copy link

Preview staging links for this PR:

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

Copy link
Member

@tkajtoch tkajtoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look great! I like the simplicity of adding flags as another theme object. It's perfect for our current use case

@mgadewoll mgadewoll merged commit 0de3e80 into elastic:eui-theme/borealis Nov 5, 2024
4 checks passed
mgadewoll added a commit that referenced this pull request Nov 8, 2024
mgadewoll added a commit that referenced this pull request Nov 13, 2024
tkajtoch pushed a commit that referenced this pull request Nov 20, 2024
tkajtoch pushed a commit that referenced this pull request Nov 27, 2024
tkajtoch pushed a commit that referenced this pull request Dec 16, 2024
tkajtoch pushed a commit that referenced this pull request Dec 17, 2024
mgadewoll added a commit that referenced this pull request Jan 7, 2025
mgadewoll added a commit to mgadewoll/eui that referenced this pull request Jan 20, 2025
mgadewoll added a commit to mgadewoll/eui that referenced this pull request Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants