[EuiBasicTable][EuiInMemoryTable][EuiDataGrid] Update to use EuiTablePagination component defaults
#6993
Commits on Aug 1, 2023
-
Refactor EuiTablePagination defaults to a separate file
- will be required/used by tables & grids shortly - hook is an extra syntactical sugar bonus that *should* only be needed by this specific table pagination use case
-
[breaking] Change EuiTablePagination's defaults to match basic/memory…
… table's defaults - these higher level components are the ones actually using these defaults anyway; we should defer to current production usage
-
Update EuiInMemoryTable to use EuiTablePagination defaults
- requires some class-specific syntax/workarounds
-
[tech debt] Fix remaining EuiInMemoryTable pagination tests
- pagination now requires the correct context provider, which our RTL render provides by default but Enzyme doesn't - we might as well reduce our snapshot footprint and write more specific assertions while here (note: this isn't perfect/complete, but it's a good start)
-
-
[EuiDataGrid] Convert pagination to use EuiProvider
componentDefaults+ update props documentation
-
[EuiDataGrid] Fix remaining grid usages of
pageSize- anything that gets the current visible row index (e.g. focus) needs pageSize propagated from defaults + update types to reflect that internal `pagination` references should have all required props
-
[docs] Update all EuiDataGrid examples to remove unnecessary `pageSiz…
…e` / `pageSizeOptions` props - there's a few left, e.g. virtualization, and the focus example, where custom page sizes makes sense, but overall most do not need to set a custom page size
-
[docs] Fix EuiBasicTable/EuiInMemoryTable props tabs not correctly lo…
…ading `@default`s
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.