Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiBasicTable][EuiInMemoryTable][EuiDataGrid] Update to use EuiTablePagination component defaults #6993

Commits on Aug 1, 2023

  1. Refactor EuiTablePagination defaults to a separate file

    - will be required/used by tables & grids shortly
    
    - hook is an extra syntactical sugar bonus that *should* only be needed by this specific table pagination use case
    cee-chen committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    c3adb11 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    34bb285 View commit details
    Browse the repository at this point in the history
  3. [breaking] Change EuiTablePagination's defaults to match basic/memory…

    … table's defaults
    
    - these higher level components are the ones actually using these defaults anyway; we should defer to current production usage
    cee-chen committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    4f5f219 View commit details
    Browse the repository at this point in the history
  4. Update EuiInMemoryTable to use EuiTablePagination defaults

    - requires some class-specific syntax/workarounds
    cee-chen committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    40ae0a8 View commit details
    Browse the repository at this point in the history
  5. [tech debt] Fix remaining EuiInMemoryTable pagination tests

    - pagination now requires the correct context provider, which our RTL render provides by default but Enzyme doesn't
    
    - we might as well reduce our snapshot footprint and write more specific assertions while here (note: this isn't perfect/complete, but it's a good start)
    cee-chen committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    89828a5 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    81aeac6 View commit details
    Browse the repository at this point in the history
  7. [EuiDataGrid] Convert pagination to use EuiProvider componentDefaults

    + update props documentation
    cee-chen committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    6ff1312 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    4692049 View commit details
    Browse the repository at this point in the history
  9. [EuiDataGrid] Fix remaining grid usages of pageSize

    - anything that gets the current visible row index (e.g. focus) needs pageSize propagated from defaults
    
    + update types to reflect that internal `pagination` references should have all required props
    cee-chen committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    ce262d0 View commit details
    Browse the repository at this point in the history
  10. [docs] Update all EuiDataGrid examples to remove unnecessary `pageSiz…

    …e` / `pageSizeOptions` props
    
    - there's a few left, e.g. virtualization, and the focus example, where custom page sizes makes sense, but overall most do not need to set a custom page size
    cee-chen committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    19cf73b View commit details
    Browse the repository at this point in the history
  11. changelog

    cee-chen committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    a69b3f5 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    84899e8 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    8b2e9a0 View commit details
    Browse the repository at this point in the history