Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiTablePagination] Allow page size props to be configured via EuiProvider.componentProps #6951

Commits on Jul 14, 2023

  1. [setup] Misc EuiPortal cleanup

    - we're going to need this extra specificity shortly for when we add internal context defaults
    cee-chen committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    c4bd1b1 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2023

  1. Set up opinionated EUI baseline component defaults in the context

    - I played around with it, but unfortunately it doesn't makse sense to define the defaults in the component itself still. You either run into dependency issues (if you try to import them) or you have a lot of extra `??` repeated code if you try to make an extra layer of fallbacks
    cee-chen committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    fbcbd29 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b21664a View commit details
    Browse the repository at this point in the history
  3. [setup] Misc EuiTablePaginationCleanup

    - convert tests to RTL
    
    - remove unnecessary `() => {}` callback default (since prop is not required), use optional chaining instead
    cee-chen committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    b1fda8c View commit details
    Browse the repository at this point in the history
  4. Update EuiTablePagination to use defaults context

    - default props must be manually declared using jsdocs now, since react docgen can no longer use `=` fallbacks to figure them out
    
    - note: setting `EuiTablePagination.defaultProps` unfortunately does not work, React will automatically populate them and they don't come in as undefined
    cee-chen committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    d722be1 View commit details
    Browse the repository at this point in the history
  5. [tests][cleanup] De-dupe EuiTablePagination and PaginationBar tests

    - PaginationBar should not be testing props that are basic pass-throughs - EuiTablePagination should (the whole point of unit tests)
    + add test for PaginationBar logic that's actually there (onPageChange)
    
    - Move said missing tests to EuiTablePagination and improve tests to use specific assertions instead of noisy snapshots
    cee-chen committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    37ff1c3 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2023

  1. Configuration menu
    Copy the full SHA
    8695bb3 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2023

  1. Configuration menu
    Copy the full SHA
    8dcf924 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3a44a79 View commit details
    Browse the repository at this point in the history
  3. Rename useEuiComponentDefaults to just useComponentDefaults

    - to make it (maybe??) a bit clearer that component defaults in this context are 100% from the consumer and 0% from EUI at this point
    cee-chen committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    4f8a621 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4f5f225 View commit details
    Browse the repository at this point in the history
  5. Remove need for EuiComponentDefaultsSupportedComponents

    via the magic of an inferred generic
    cee-chen committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    28523ea View commit details
    Browse the repository at this point in the history
  6. changelog

    cee-chen committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    f303f96 View commit details
    Browse the repository at this point in the history