-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiTablePagination] Allow page size props to be configured via EuiProvider.componentProps
#6951
[EuiTablePagination] Allow page size props to be configured via EuiProvider.componentProps
#6951
Commits on Jul 14, 2023
-
[setup] Misc EuiPortal cleanup
- we're going to need this extra specificity shortly for when we add internal context defaults
Configuration menu - View commit details
-
Copy full SHA for c4bd1b1 - Browse repository at this point
Copy the full SHA c4bd1b1View commit details
Commits on Jul 15, 2023
-
Set up opinionated EUI baseline component defaults in the context
- I played around with it, but unfortunately it doesn't makse sense to define the defaults in the component itself still. You either run into dependency issues (if you try to import them) or you have a lot of extra `??` repeated code if you try to make an extra layer of fallbacks
Configuration menu - View commit details
-
Copy full SHA for fbcbd29 - Browse repository at this point
Copy the full SHA fbcbd29View commit details -
Configuration menu - View commit details
-
Copy full SHA for b21664a - Browse repository at this point
Copy the full SHA b21664aView commit details -
[setup] Misc EuiTablePaginationCleanup
- convert tests to RTL - remove unnecessary `() => {}` callback default (since prop is not required), use optional chaining instead
Configuration menu - View commit details
-
Copy full SHA for b1fda8c - Browse repository at this point
Copy the full SHA b1fda8cView commit details -
Update EuiTablePagination to use defaults context
- default props must be manually declared using jsdocs now, since react docgen can no longer use `=` fallbacks to figure them out - note: setting `EuiTablePagination.defaultProps` unfortunately does not work, React will automatically populate them and they don't come in as undefined
Configuration menu - View commit details
-
Copy full SHA for d722be1 - Browse repository at this point
Copy the full SHA d722be1View commit details -
[tests][cleanup] De-dupe EuiTablePagination and PaginationBar tests
- PaginationBar should not be testing props that are basic pass-throughs - EuiTablePagination should (the whole point of unit tests) + add test for PaginationBar logic that's actually there (onPageChange) - Move said missing tests to EuiTablePagination and improve tests to use specific assertions instead of noisy snapshots
Configuration menu - View commit details
-
Copy full SHA for 37ff1c3 - Browse repository at this point
Copy the full SHA 37ff1c3View commit details
Commits on Jul 20, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 8695bb3 - Browse repository at this point
Copy the full SHA 8695bb3View commit details
Commits on Jul 25, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 8dcf924 - Browse repository at this point
Copy the full SHA 8dcf924View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3a44a79 - Browse repository at this point
Copy the full SHA 3a44a79View commit details -
Rename
useEuiComponentDefaults
to justuseComponentDefaults
- to make it (maybe??) a bit clearer that component defaults in this context are 100% from the consumer and 0% from EUI at this point
Configuration menu - View commit details
-
Copy full SHA for 4f8a621 - Browse repository at this point
Copy the full SHA 4f8a621View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f5f225 - Browse repository at this point
Copy the full SHA 4f5f225View commit details -
Remove need for
EuiComponentDefaultsSupportedComponents
via the magic of an inferred generic
Configuration menu - View commit details
-
Copy full SHA for 28523ea - Browse repository at this point
Copy the full SHA 28523eaView commit details -
Configuration menu - View commit details
-
Copy full SHA for f303f96 - Browse repository at this point
Copy the full SHA f303f96View commit details