Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Emotion] Convert EuiBadgeGroup, EuiBetaBadge, and EuiNotificationBadge #6258

Merged
merged 8 commits into from
Sep 23, 2022
Merged

[Emotion] Convert EuiBadgeGroup, EuiBetaBadge, and EuiNotificationBadge #6258

merged 8 commits into from
Sep 23, 2022

Commits on Sep 21, 2022

  1. Convert EuiBadgeGroup to Emotion 

    - opinionated refactor: Use `inline-flex` and `gap` instead of inline-block and margins

- doing so remove the needs for `euiBadgeGroup__item`
    @cee-chen
    cee-chen committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    441dec2 View commit details
    Browse the repository at this point in the history

  2. Convert EuiBetaBadge to Emotion 

    - opinionated refactor: simplify `s` font-size to static rem (since .625 doesn't match the ratio of any current font scales)

- remove isClickable CSS / classNames - it's not actually being used anywhere that I can tell

- add unit tests for badge circle display
    @cee-chen
    cee-chen committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    9c99675 View commit details
    Browse the repository at this point in the history

  3. [docs] beta badge docs improvement 

    - convert file to TS
- improve visuals of clickable examples
    @cee-chen
    cee-chen committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    0aa36ae View commit details
    Browse the repository at this point in the history

  4. Convert EuiNotificationBadge to Emotion 

    + delete all badge SCSS files

+ update downstream snapshots
    @cee-chen
    cee-chen committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    6ac237d View commit details
    Browse the repository at this point in the history

  5. changelog

    @cee-chen
    cee-chen committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    3175424 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2022

  1. [PR feedback] euiTextTruncate

    @cee-chen
    cee-chen committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    feb1bb6 View commit details
    Browse the repository at this point in the history

  2. [PR feedback] Create internal color util for badge colors

    @cee-chen
    cee-chen committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    e3ddcd0 View commit details
    Browse the repository at this point in the history

  3. [PR feedback] Remove  s from beta badge docs

    @cee-chen
    cee-chen committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    9f81e53 View commit details
    Browse the repository at this point in the history