[Emotion] Fix multiple css props not being properly cascaded/merged to child props #6239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ add regression tests for child props
cee-chen
force-pushed
the
child-props-css
branch
from
7dc2956
to
818c436
Compare
|
I'll be OOO until afternoon Pacific Time tomorrow. If this looks sane to folks feel free to merge/backport release this into 64.04 for elastic/kibana#140323. Otherwise I can do it when I get back |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6239/ |
1Copenut
approved these changes
Sep 15, 2022
There was a problem hiding this comment.
Your PR description is one I'm going to refer back to often. It defined the problem space perfectly, outlining that Emotion CSS must be defined before {...props} or the CSS won't merge correctly.
Commit 5f4af08 really helped me understand the intent.
The PR looks good to me. I'll wait to hear from one more reviewer before merging.
chandlerprall
approved these changes
Sep 15, 2022
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6239/ |
This was referenced Sep 20, 2022
2 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
See elastic/kibana#140706 (comment)
This PR fixes the
cssprop being passed to various childcomponentPropsnot correctly mergingcss. Apparently Emotion generally requires ourcss={}definition to come before the{...props}spread for it to be combined correctly.Or in the case of
EuiPageSection, it requires the concatenation to occur in our Emotion styles array declaration (I think becausecontentPropshas no classNames on it).NOTE:
panelPropsstyle. Still trying to figure out/think on how to ignore that, and it's getting late + I'm about to go on PTO so I figured I'd get this in sooner rather than later.Checklist