[EuiProvider] Change location of fallback Emotion cache #6202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
cee-chen
reviewed
Sep 1, 2022
cee-chen
reviewed
Sep 1, 2022
| defaultCache = cache.default; | ||
| globalCache = cache.global; | ||
| utilityCache = cache.utility; | ||
| } | ||
| } | ||
| return ( | ||
| <EuiCacheProvider cache={defaultCache}> | ||
| <EuiCacheProvider cache={defaultCache ?? fallbackCache}> |
There was a problem hiding this comment.
Is this necessary? it should be covered by the = fallbackCache above, right?
There was a problem hiding this comment.
Not if some one configures like cache={{ global: globalCache }}
This is for the granular case.
cee-chen
reviewed
Sep 1, 2022
Comment on lines
+87
to
90
| if (cache.default) { | ||
| cache.default.compat = true; | ||
| } | ||
| defaultCache = cache.default; |
There was a problem hiding this comment.
oh actually i think i see (re above comment)... we make each nested cache optional.
tbh though, why not make cache.default required and skip the conditional check? or make them all required? how likely are consumers to pass a cache just for global styles or just for utility styles?
cee-chen
approved these changes
Sep 1, 2022
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6202/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6202/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Having the fallback cache configured for each
EuiCacheProviderbroke the context "bubbling" fallback assumed byEuiProvider, resulting in thedefaultCacheinEuiProvidernot being the catch-all location for Emotion styles. The net effect is that global styles were being inserted after component styles when not configured withEuiProvider.cache.global(such is the case in the docs).The fix is to move the fallback to be the default prop value in
EuiProviderrather thanEuiCacheProvider.Also, the
defaultCachewill always getcompat=true, even if consumers forget to add it.Before
After
Checklist