-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove all IE JS fallbacks and workarounds #6162
Conversation
- In my testing, `relatedTarget` was correctly present and `explicitOriginalTarget` almost always returned undefined
- Edge testing with tabIndex={-1} was working as expected for me
Preview documentation changes for this PR: https://eui.elastic.co/pr_6162/ |
Is this a breaking change? We don't support IE11 anymore so further unsupporting it it further shouldn't be a break by itself. |
I labelled it as one to keep the changelog grouped with the other IE CSS removals (some of which are technically breaking changes because we're removing a CSS util and a Sass mixin). It probably technically isn't but it may not be a bad thing to stress we no longer support IE 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested changes locally in various browsers to confirm things still work as expected
Summary
The JS version of #6154 and #6161.
Components to QA
tabindex="-1" id="test"
to any icondocument.getElementById('test').focus()
, press enterdocument.activeElement
, press enter and confirm it's the SVG/icon abovetabindex
attribute to0
and then confirm you can now focus the icon via tabbingChecklist
- [ ] Checked in both light and dark modes- [ ] Checked in mobile- [ ] Props have proper autodocs and playground toggles- [ ] Added documentation- [ ] Checked Code Sandbox works for any docs examples- [ ] Added or updated jest and cypress tests- [ ] Updated the Figma library counterpart