Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiSelectable] Fix keyboard events not persisting to onChange callbacks #6045

Merged
merged 2 commits into from
Jul 12, 2022
Merged

[EuiSelectable] Fix keyboard events not persisting to onChange callbacks #6045

merged 2 commits into from
Jul 12, 2022

Conversation

cee-chen
Copy link
Contributor

@cee-chen cee-chen commented Jul 12, 2022 •
edited
Loading

Summary

🤦 I completely missed this in #6026. Just throw my body in the trash

Checklist

  • Tested against React v16
  • A changelog entry exists and is marked appropriately

@cee-chen cee-chen requested a review from chandlerprall July 12, 2022 17:05
chandlerprall
chandlerprall reviewed Jul 12, 2022
View reviewed changes
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ❤️

@cee-chen
Copy link
Contributor Author

Going to test against local Kibana really quick first

thompsongl
thompsongl approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @constancecchen!

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_6045/

@cee-chen
Copy link
Contributor Author

OK, definitively tested and confirmed as working on Kibana

@cee-chen cee-chen marked this pull request as ready for review July 12, 2022 17:58
@cee-chen cee-chen merged commit eb493ff into elastic:main Jul 12, 2022
@cee-chen cee-chen deleted the selectable/keyboard-event branch July 12, 2022 17:59
@breehall breehall mentioned this pull request Jul 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chandlerprall chandlerprall chandlerprall approved these changes

@thompsongl thompsongl thompsongl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cee-chen @kibanamachine @chandlerprall @thompsongl