-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiDataGrid] Enhance column header actions popover to be keyboard navigable with up/down arrow keys #6017
[EuiDataGrid] Enhance column header actions popover to be keyboard navigable with up/down arrow keys #6017
Conversation
010fd29
to
dd38910
Compare
Also wanted to mention - I did spike out converting TL;DR I found it easier to write a bunch of index if statements lol 🤪 |
Preview documentation changes for this PR: https://eui.elastic.co/pr_6017/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really liking this enhancement. I left one copy suggestion / question, but have no items specifically to change. LGTM!
Preview documentation changes for this PR: https://eui.elastic.co/pr_6017/ |
src/components/datagrid/body/header/__snapshots__/data_grid_header_cell.test.tsx.snap
Outdated
Show resolved
Hide resolved
Preview documentation changes for this PR: https://eui.elastic.co/pr_6017/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; tested in the PR's published docs. ❤️ those tests
Summary
EuiDataGrid changes
closes #4642
Look ma, no mouse!
Implementation should still respect native
Tab
behavior as it works off ofdocument.activeElement
.EuiPopover changes
popoverScreenReaderText
prop to allow adding custom keyboard navigation instructions for SR users (689dd44):Checklist
- [ ] Checked in both light and dark modes- [ ] Checked in mobile- [ ] Props have proper autodocs and playground toggles- [ ] Added documentation- [ ] Checked Code Sandbox works for any docs examples- [ ] Checked for breaking changes and labeled appropriately- [ ] Updated the Figma library counterpart