Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiSuggest] Accept isPreFiltered prop #5930

Merged
merged 4 commits into from
Sep 6, 2022

Conversation

omar-zahid
Copy link
Contributor

@omar-zahid omar-zahid commented May 25, 2022

Summary

EuiSuggest props currently does not accept isPreFiltered prop which does exist in the Selectable component.

From the documents, isPreFiltered:

Control whether or not options get filtered internally or if consumer will filter Default: false

Recommending to allow EuiSuggest component to accept isPreFiltered prop to introduce the same functionality above to EuiSuggest component

Checklist

  • Checked in both light and dark modes
  • Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
  • Props have proper autodocs and playground toggles
  • Added documentation
  • Checked Code Sandbox works for any docs examples
  • Added or updated jest and cypress tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • Updated the Figma library counterpart
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cla-checker-service
Copy link

cla-checker-service bot commented May 25, 2022

💚 CLA has been signed

@thompsongl
Copy link
Contributor

Hey @omar-zahid,

When you're ready for review, please update the summary and check or remove each checklist item. Also, sign the CLA if you haven't already done so.

Thanks!

@omar-zahid
Copy link
Contributor Author

Thanks @thompsongl Sure. I have also signed the CLA however its not being reflected as signed here, not sure why.

@thompsongl
Copy link
Contributor

Thanks! Could you also add a changelog entry?

jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_5930/

@github-actions
Copy link

👋 Hey there. This PR hasn't had any activity for 90 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

@thompsongl
Copy link
Contributor

Hey @omar-zahid
Do you still want to see this PR merged? If you don't have time to finish it, we can take over from here.

Just let us know! Thanks again for helping out!

@github-actions github-actions bot removed the stale-pr label Sep 1, 2022
@omar-zahid
Copy link
Contributor Author

Hi @thompsongl Sorry been away for a while. It would be helpful if you can take it from here. I would love to have this feature merged in.
Apologies again for the delay.

@thompsongl
Copy link
Contributor

Not a problem! We will get the branch updated and this PR merged.

@thompsongl
Copy link
Contributor

jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_5930/

@thompsongl thompsongl marked this pull request as ready for review September 6, 2022 16:00
@thompsongl thompsongl enabled auto-merge (squash) September 6, 2022 16:01
@thompsongl thompsongl merged commit 1fbcae8 into elastic:main Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants