[EuiPanel] Revert removing padding classes #5927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 24, 2022 18:22
This reverts commit 6cd38cc.
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5927/ |
thompsongl
approved these changes
May 25, 2022
cee-chen
pushed a commit
to cee-chen/eui
that referenced
this pull request
May 26, 2022
* Revert "[Review Feedback]:" This reverts commit 6cd38cc. * Update comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a commit-revert from #5891
The classNames are used by EuiPopover and parts to create padding. I just reverted all changes to this back to the working state and added the previously suggested additional comment to the
@ts-expect-errorstatements.All the examples at
/layout/popover#popover-padding-sizesshould be working againBefore
After
Checklist
[ ] Checked in both light and dark modes[ ] Checked in mobile[ ] Checked in Chrome, Safari, Edge, and Firefox[ ] Props have proper autodocs and **[playground toggles](https://github.com/elastic/eui/blob/main/wiki/documentation-guidelines.md#adding-playground-toggles)**~[ ] Added documentation[ ] Checked Code Sandbox works for any docs examples[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes