[Docs] Fix scroll to hash behavior #5915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5915/ |
|
CLA status appears to have hung |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5915/ |
elizabetdev
approved these changes
May 23, 2022
There was a problem hiding this comment.
Thanks, @constancecchen. It looks great! 🎉
Tested in Chrome, Safari, Edge, and, Firefox.
thompsongl
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
From @miukimiu
This PR adds a document readystate check to ensure DOM is done loading/shifting before scrolling to a hash section.
It also tweaks the header offset slightly account for new section spacing added in #5887
Checklist
Other items are probably N/A as an internal only change