Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiDataGrid] Fix cells losing focus state when scrolled out of view #5488

Merged
merged 8 commits into from
Dec 28, 2021
Merged

[EuiDataGrid] Fix cells losing focus state when scrolled out of view #5488

merged 8 commits into from
Dec 28, 2021

Commits on Dec 16, 2021

  1. [Setup] Add focusedCell state to shared focus context 

    - will be used by cells to check if they're the currently focused cell
    @cee-chen
    cee-chen committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    df1ba21 View commit details
    Browse the repository at this point in the history

  2. Update EuiDataGridCell to handle virtualization 

    - by mounting with focus state (when cells scroll back into view)
    @cee-chen
    cee-chen committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    bfafed0 View commit details
    Browse the repository at this point in the history

  3. Misc unit test mount fix 

    - Remove mountEuiDataGridCellWithContext helper - the context wasn't actually getting used (it was falling back to the default context), and wasn't needed by most tests, and the tests that do need it can manually mount() with <DataGridFocusContext.Provider> as a wrapper
    @cee-chen
    cee-chen committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    45d793f View commit details
    Browse the repository at this point in the history

  4. Fix misc documentation typos

    @cee-chen
    cee-chen committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    5a15d7f View commit details
    Browse the repository at this point in the history

  5. Add changelog entry

    @cee-chen
    cee-chen committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    3ae6ad8 View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2021

  1. Merge branch 'main' into datagrid/5047

    @cee-chen
    cee-chen committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    2e87b01 View commit details
    Browse the repository at this point in the history

  2. [PR feedback] Prevent focus scroll on virtualization re-mount 

    - since the user is presumably already scrolling, there's no need to hijack their current scroll
    @cee-chen
    cee-chen committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    74cee85 View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2021

  1. Merge branch 'main' into datagrid/5047

    Constance authored Dec 22, 2021
    Configuration menu
    Copy the full SHA
    42601d3 View commit details
    Browse the repository at this point in the history