Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiDataGrid] Add lineHeight configuration to rowHeightsOptions #5221

Merged
merged 8 commits into from
Sep 30, 2021
Merged

[EuiDataGrid] Add lineHeight configuration to rowHeightsOptions #5221

merged 8 commits into from
Sep 30, 2021

Commits on Sep 28, 2021

  1. Added lineHeight configuration to rowHeightOptions

    @chandlerprall @cee-chen
    chandlerprall authored and cee-chen committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    9c0ac2c View commit details
    Browse the repository at this point in the history

  2. Changelog entry

    @cee-chen
    cee-chen committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    332ccfa View commit details
    Browse the repository at this point in the history

  3. Add documentation section + example 

    - Add new example that uses same dataset as other 2 on page, but makes it text only (lineHeight doesn't work as expected with nested <EuiText>

- Update existing documentation, make 'fixed' example more of a demo of rowHeights overrides
    @cee-chen
    cee-chen committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    cc59b27 View commit details
    Browse the repository at this point in the history

  4. Misc existing documentation fixes 

    - Fix awkward grammar which was tweaked in another spot in the docs

- fix defaultHeight snippet example that was missing a closing brace (change it to static #, since I added a lineCount example already earlier in the page)

- fix redundant =
    @cee-chen
    cee-chen committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    dcf2e9d View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2021

  1. [PR feedback] Documentation copy 

    Co-authored-by: Elizabet Oliveira <elizabet.oliveira@elastic.co>
    @miukimiu
    Constance and miukimiu authored Sep 30, 2021
    Configuration menu
    Copy the full SHA
    69d77e2 View commit details
    Browse the repository at this point in the history

  2. [PR feedback] Capitalization

    @cee-chen
    cee-chen committed Sep 30, 2021
    Configuration menu
    Copy the full SHA
    0f5a4f7 View commit details
    Browse the repository at this point in the history

  3. Add rowHeightsOptions to main data grid docs page

    @cee-chen
    cee-chen committed Sep 30, 2021
    Configuration menu
    Copy the full SHA
    55a1069 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'datagrid-lineheight' of github.com:constancecchen/eui i… 

    …nto datagrid-lineheight
    @cee-chen
    cee-chen committed Sep 30, 2021
    Configuration menu
    Copy the full SHA
    5ba452a View commit details
    Browse the repository at this point in the history