-
Notifications
You must be signed in to change notification settings - Fork 840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Amsterdam] Fixed EuiButtonGroup's border-radius and font-weight, and Fixed EuiButton's text color for text colors #5177
Conversation
Preview documentation changes for this PR: https://eui.elastic.co/pr_5177/ |
Preview documentation changes for this PR: https://eui.elastic.co/pr_5177/ |
@miukimiu Can I get your review on this one since it's mostly styling? |
Preview documentation changes for this PR: https://eui.elastic.co/pr_5177/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🎉
Tested in Chrome, Safari, Edge and, Firefox. I also looked at the code. 👍🏽
Co-authored-by: Elizabet Oliveira <elizabet.oliveira@elastic.co>
Preview documentation changes for this PR: https://eui.elastic.co/pr_5177/ |
[EuiButtonGroup] Fixed border-radius and font-weight for Amsterdam theme
The
small
group wasn't getting the right border-radius size because of inheritance. And the font-weight wasn't increased when we did so for the other buttons.Before (button vs button group)
After
[EuiButton] Fixed text color for text colored buttons to have more contrast using
$euiTextColor
Following the pattern that was actually already set in EuiButtonGroup to make the text more visible in text colored buttons (EuiButton and EuiIconButton), I swapped those to manually get the
$euiTextColor
. This also helps to further differentiate it from disabled buttons. 🤞Before
After
Checklist
- [ ] Checked in mobile- [ ] Props have proper autodocs and playground toggles- [ ] Added documentation- [ ] Checked Code Sandbox works for any docs examples- [ ] Added or updated jest tests- [ ] Checked for breaking changes and labeled appropriately- [ ] Checked for accessibility including keyboard-only and screenreader modes