Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove EuiPageSideProps from src/components/index.js export #4604

Merged
merged 3 commits into from
Mar 3, 2021

Conversation

chandlerprall
Copy link
Contributor

Summary

Removes an additional exported type identified in #4597 (comment). This one wasn't reported during a webpack build presumably because its source file does export * from compared to the explicit export { ComponentProps} pattern which exported the others. This is the last occurrence of props in src/components/index.js.

Looked into making CI fail if webpack issued the warning about an unknown import but decided against for a few reasons:

  • looks like it requires adding a plugin e.g. https://www.npmjs.com/package/fail-on-errors-webpack-plugin
  • we'd have to shoe-horn it into the CI environment for dist build or devserver+axe configurations, which is brittle
  • final conversion of index.js->TypeScript will need to handle this in an entirely different way

So to me it isn't worth it, but I can be told otherwise :)

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦 Thanks!

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4604/

@chandlerprall chandlerprall merged commit 58a4035 into elastic:master Mar 3, 2021
@chandlerprall chandlerprall deleted the exported-types-cleanup branch March 3, 2021 19:45
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4604/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants