Remove EuiPageSideProps from src/components/index.js export #4604
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes an additional exported type identified in #4597 (comment). This one wasn't reported during a webpack build presumably because its source file does
export * from
compared to the explicitexport { ComponentProps}
pattern which exported the others. This is the last occurrence ofprops
in src/components/index.js.Looked into making CI fail if webpack issued the warning about an unknown import but decided against for a few reasons:
dist
build or devserver+axe configurations, which is brittleSo to me it isn't worth it, but I can be told otherwise :)