Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiPopover] Don't apply willChange to popover after it is done opening & animating #4590

Merged
merged 3 commits into from
Mar 3, 2021
Merged

[EuiPopover] Don't apply willChange to popover after it is done opening & animating #4590

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b11e182
Don't apply willChange to popover after it is done opening & animating
chandlerprall Mar 1, 2021
533726b
changelog
chandlerprall Mar 2, 2021
80fb5bd
Merge branch 'master' into bug/4574-popover-willchange-offsetparent
chandlerprall Mar 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
**Bug fixes**

- Fixed hover effect of nested clickable rows in `EuiBasicTable` ([#4566](https://github.com/elastic/eui/pull/4566))
- Fixed visual bug in drag&drop sections when nested in an popover ([#4590](https://github.com/elastic/eui/pull/4590))

## [`31.9.1`](https://github.com/elastic/eui/tree/v31.9.1)

Expand Down
6 changes: 3 additions & 3 deletions src/components/form/super_select/__snapshots__/super_select.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ exports[`EuiSuperSelect props custom display is propagated to dropdown 1`] = `
aria-modal="true"
class="euiPanel euiPanel--borderRadiusMedium euiPanel--plain euiPanel--noShadow euiPopover__panel euiPopover__panel--bottom euiPopover__panel-noArrow euiPopover__panel-isAttached"
role="dialog"
style="top: 8px; left: 0px; z-index: 2000; will-change: transform, opacity;"
style="top: 8px; left: 0px; will-change: transform, opacity; z-index: 2000;"
>
<div
class="euiPopover__panelArrow euiPopover__panelArrow--bottom"
Expand Down Expand Up @@ -444,7 +444,7 @@ exports[`EuiSuperSelect props more props are propogated to each option 1`] = `
aria-modal="true"
class="euiPanel euiPanel--borderRadiusMedium euiPanel--plain euiPanel--noShadow euiPopover__panel euiPopover__panel--bottom euiPopover__panel-noArrow euiPopover__panel-isAttached"
role="dialog"
style="top: 8px; left: 0px; z-index: 2000; will-change: transform, opacity;"
style="top: 8px; left: 0px; will-change: transform, opacity; z-index: 2000;"
>
<div
class="euiPopover__panelArrow euiPopover__panelArrow--bottom"
Expand Down Expand Up @@ -605,7 +605,7 @@ exports[`EuiSuperSelect props options are rendered when select is open 1`] = `
aria-modal="true"
class="euiPanel euiPanel--borderRadiusMedium euiPanel--plain euiPanel--noShadow euiPopover__panel euiPopover__panel--bottom euiPopover__panel-noArrow euiPopover__panel-isAttached"
role="dialog"
style="top: 8px; left: 0px; z-index: 2000; will-change: transform, opacity;"
style="top: 8px; left: 0px; will-change: transform, opacity; z-index: 2000;"
>
<div
class="euiPopover__panelArrow euiPopover__panelArrow--bottom"
Expand Down
20 changes: 10 additions & 10 deletions src/components/popover/__snapshots__/popover.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ exports[`EuiPopover props arrowChildren is rendered 1`] = `
aria-modal="true"
class="euiPanel euiPanel--paddingMedium euiPanel--borderRadiusMedium euiPanel--plain euiPanel--noShadow euiPopover__panel euiPopover__panel--bottom euiPopover__panel-isOpen"
role="dialog"
style="top: 16px; left: -22px; z-index: 2000; will-change: transform, opacity;"
style="top: 16px; left: -22px; will-change: transform, opacity; z-index: 2000;"
>
<div
class="euiPopover__panelArrow euiPopover__panelArrow--bottom"
Expand Down Expand Up @@ -157,7 +157,7 @@ exports[`EuiPopover props buffer 1`] = `
aria-modal="true"
class="euiPanel euiPanel--paddingMedium euiPanel--borderRadiusMedium euiPanel--plain euiPanel--noShadow euiPopover__panel euiPopover__panel--bottom euiPopover__panel-isOpen"
role="dialog"
style="top: 16px; left: -22px; z-index: 2000; will-change: transform, opacity;"
style="top: 16px; left: -22px; will-change: transform, opacity; z-index: 2000;"
>
<div
class="euiPopover__panelArrow euiPopover__panelArrow--bottom"
Expand Down Expand Up @@ -204,7 +204,7 @@ exports[`EuiPopover props buffer for all sides 1`] = `
aria-modal="true"
class="euiPanel euiPanel--paddingMedium euiPanel--borderRadiusMedium euiPanel--plain euiPanel--noShadow euiPopover__panel euiPopover__panel--bottom euiPopover__panel-isOpen"
role="dialog"
style="top: 16px; left: -22px; z-index: 2000; will-change: transform, opacity;"
style="top: 16px; left: -22px; will-change: transform, opacity; z-index: 2000;"
>
<div
class="euiPopover__panelArrow euiPopover__panelArrow--bottom"
Expand Down Expand Up @@ -277,7 +277,7 @@ exports[`EuiPopover props isOpen renders true 1`] = `
aria-modal="true"
class="euiPanel euiPanel--paddingMedium euiPanel--borderRadiusMedium euiPanel--plain euiPanel--noShadow euiPopover__panel euiPopover__panel--bottom euiPopover__panel-isOpen"
role="dialog"
style="top: 16px; left: -22px; z-index: 2000; will-change: transform, opacity;"
style="top: 16px; left: -22px; will-change: transform, opacity; z-index: 2000;"
>
<div
class="euiPopover__panelArrow euiPopover__panelArrow--bottom"
Expand Down Expand Up @@ -325,7 +325,7 @@ exports[`EuiPopover props offset with arrow 1`] = `
aria-modal="true"
class="euiPanel euiPanel--paddingMedium euiPanel--borderRadiusMedium euiPanel--plain euiPanel--noShadow euiPopover__panel euiPopover__panel--bottom euiPopover__panel-isOpen"
role="dialog"
style="top: 26px; left: -22px; z-index: 2000; will-change: transform, opacity;"
style="top: 26px; left: -22px; will-change: transform, opacity; z-index: 2000;"
>
<div
class="euiPopover__panelArrow euiPopover__panelArrow--bottom"
Expand Down Expand Up @@ -373,7 +373,7 @@ exports[`EuiPopover props offset without arrow 1`] = `
aria-modal="true"
class="euiPanel euiPanel--paddingMedium euiPanel--borderRadiusMedium euiPanel--plain euiPanel--noShadow euiPopover__panel euiPopover__panel--bottom euiPopover__panel-isOpen euiPopover__panel-noArrow"
role="dialog"
style="top: 18px; left: -22px; z-index: 2000; will-change: transform, opacity;"
style="top: 18px; left: -22px; will-change: transform, opacity; z-index: 2000;"
>
<div
class="euiPopover__panelArrow euiPopover__panelArrow--bottom"
Expand Down Expand Up @@ -419,7 +419,7 @@ exports[`EuiPopover props ownFocus defaults to false 1`] = `
aria-modal="true"
class="euiPanel euiPanel--paddingMedium euiPanel--borderRadiusMedium euiPanel--plain euiPanel--noShadow euiPopover__panel euiPopover__panel--bottom euiPopover__panel-isOpen"
role="dialog"
style="top: 16px; left: -22px; z-index: 2000; will-change: transform, opacity;"
style="top: 16px; left: -22px; will-change: transform, opacity; z-index: 2000;"
>
<div
class="euiPopover__panelArrow euiPopover__panelArrow--bottom"
Expand Down Expand Up @@ -468,7 +468,7 @@ exports[`EuiPopover props ownFocus renders true 1`] = `
class="euiPanel euiPanel--paddingMedium euiPanel--borderRadiusMedium euiPanel--plain euiPanel--noShadow euiPopover__panel euiPopover__panel--bottom euiPopover__panel-isOpen"
data-autofocus="true"
role="dialog"
style="top: 16px; left: -22px; z-index: 2000; will-change: transform, opacity;"
style="top: 16px; left: -22px; will-change: transform, opacity; z-index: 2000;"
tabindex="0"
>
<div
Expand Down Expand Up @@ -522,7 +522,7 @@ exports[`EuiPopover props panelClassName is rendered 1`] = `
aria-modal="true"
class="euiPanel euiPanel--paddingMedium euiPanel--borderRadiusMedium euiPanel--plain euiPanel--noShadow euiPopover__panel euiPopover__panel--bottom euiPopover__panel-isOpen test"
role="dialog"
style="top: 16px; left: -22px; z-index: 2000; will-change: transform, opacity;"
style="top: 16px; left: -22px; will-change: transform, opacity; z-index: 2000;"
>
<div
class="euiPopover__panelArrow euiPopover__panelArrow--bottom"
Expand Down Expand Up @@ -569,7 +569,7 @@ exports[`EuiPopover props panelPaddingSize is rendered 1`] = `
aria-modal="true"
class="euiPanel euiPanel--paddingSmall euiPanel--borderRadiusMedium euiPanel--plain euiPanel--noShadow euiPopover__panel euiPopover__panel--bottom euiPopover__panel-isOpen"
role="dialog"
style="top: 16px; left: -22px; z-index: 2000; will-change: transform, opacity;"
style="top: 16px; left: -22px; will-change: transform, opacity; z-index: 2000;"
>
<div
class="euiPopover__panelArrow euiPopover__panelArrow--bottom"
Expand Down
12 changes: 8 additions & 4 deletions src/components/popover/popover.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,7 +462,7 @@ export class EuiPopover extends Component<Props, State> {

// for each child element of `this.panel`, find any transition duration we should wait for before stabilizing
const { durationMatch, delayMatch } = Array.prototype.slice
.call(this.panel ? this.panel.children : [])
.call(this.panel ? [this.panel, ...Array.from(this.panel.children)] : [])
.reduce(
({ durationMatch, delayMatch }, element) => {
const transitionTimings = getTransitionTimings(element);
Expand Down Expand Up @@ -603,8 +603,6 @@ export class EuiPopover extends Component<Props, State> {
? anchorBoundingBox.left
: left,
zIndex,
// Adding `will-change` to reduce risk of a blurry animation in Chrome 86+
willChange: 'transform, opacity',
};

const willRenderArrow = !this.props.attachToAnchor && this.props.hasArrow;
Expand Down Expand Up @@ -774,7 +772,13 @@ export class EuiPopover extends Component<Props, State> {
aria-labelledby={ariaLabelledBy}
aria-modal="true"
aria-describedby={ariaDescribedby}
style={this.state.popoverStyles}>
style={{
...this.state.popoverStyles,
// Adding `will-change` to reduce risk of a blurry animation in Chrome 86+
willChange: !this.state.isOpenStable
? 'transform, opacity'
: undefined,
}}>
<div className={arrowClassNames} style={this.state.arrowStyles}>
{arrowChildren}
</div>
Expand Down