-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Data Grid] Added closePopover action to EuiDataGridColumnCellActionProps #4346
[Data Grid] Added closePopover action to EuiDataGridColumnCellActionProps #4346
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
jenkins test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_4346/ |
jenkins test this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sulemanof one thing, could you make use of this function in one of the examples of our documentation ? think it's always good to show such things in action, many thx! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Echo @kertal. A simple example (probably on the popover's doc page) for the docs would be nice. Although this is a simple prop, a jest test would also be nice. Otherwise feature looks good.
The next release for EUI will be tuesday. That will likely be the last release to get into Kibana.
…se_popover_action # Conflicts: # CHANGELOG.md
Hey @snide ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Talked with @chandlerprall yesterday. He was OK with this one going without tests. Thanks for the docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reverted the cell action example's email column to still alert so it doesn't feel broken and touched up the description. I also changed it to always pass the closePopover
method so 1) the consuming app doesn't need to test for it and 2) it is possible to click the non-popover action button when the popover is open
Will merge on passing CI
jenkins test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_4346/ |
Summary
Allow a custom cell action to close the popover manually.
The original request in Data table vis replacement -> elastic/kibana#70801 (comment)
The desired result:
Checklist