[EuiSelectable] export SiteWideRenderOptions and wire-up isPreFiltered
#4305
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4305/ |
myasonik
force-pushed
the
fix-selectable-highlight
branch
from
6dfb861
to
a0e2722
Compare
myasonik
changed the title
isPreFiltered
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4305/ |
There was a problem hiding this comment.
Looked at the code and LGTM!
But @chandlerprall or @thompsongl are probably more indicated to do the review.
| @@ -288,6 +288,7 @@ export { | |||
| EuiSelectableMessage, | |||
| EuiSelectableSearch, | |||
| EuiSelectableTemplateSitewide, | |||
| euiSelectableTemplateSitewideRenderOptions, | |||
There was a problem hiding this comment.
@cchaos I noticed that you named this euiSelectableTemplateSitewideRenderOptions starting with a lower e. Was this on purpose? Is it because is not a type?
There was a problem hiding this comment.
It isn't a type and not a "proper" React component that can be used in JSX, but is a function which happens to return a React element. Because it's only a function, it begins with lowercase.
|
Merging this as @myasonik is out today. |
Summary
Fixes #4277
This PR does two things:
euiSelectableTemplateSitewideRenderOptionsso that consumers can customize therenderOptionaround it while still using the same option componentsearchValuethat gets passed in to control highlightingisPreFilteredto be passed into the component and pass it along to the sorting function. (The sorting function already supported this flag but there was no way to use it.)Checklist
Also tested changes in Kibana confirming everything works.
[ ] Check against all themes for compatibility in both light and dark modes[ ] Checked in mobile[ ] Checked in Chrome, Safari, Edge, and Firefox[ ] Added documentation[ ] Checked Code Sandbox works for the any docs examples[ ] Checked for accessibility including keyboard-only and screenreader modes