[EuiAvatar] Remove faux border #4255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 11, 2020 15:10
This reverts commit 467a0b8.
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4255/ |
miukimiu
approved these changes
Nov 12, 2020
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4255/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amsterdam only
The original idea came about because I saw the usage of someone uploading an SVG as the avatar but the faux border made it look awkard:
So in Amsterdam, I just completely removed this faux border. It's hardly noticeable when using initials only, just when using an image with a mostly white background.
And the Kibana Spaces example:
Checklist
[ ] Checked in mobile[ ] Props have proper autodocs[ ] Added documentation[ ] Checked Code Sandbox works for the any docs examples[ ] Added or updated jest tests[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes