Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiForm] Add a11y labels to the EuiCallOut for validation errors #4238

Merged
merged 1 commit into from
Nov 9, 2020
Merged

[EuiForm] Add a11y labels to the EuiCallOut for validation errors #4238

merged 1 commit into from
Nov 9, 2020

Conversation

afharo
Copy link
Member

@afharo afharo commented Nov 9, 2020

Summary

This PR adds the accessibility labels to the EuiCallOut used in EuiForm to show the validation errors. More details in elastic/kibana#43000.

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
  • Props have proper autodocs
  • Added documentation
  • Checked Code Sandbox works for the any docs examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@afharo afharo force-pushed the a11y/EuiForm-errors-EuiCallout branch from b53fac6 to 5cde5e2 Compare November 9, 2020 14:25
@afharo afharo marked this pull request as ready for review November 9, 2020 14:25
@afharo afharo mentioned this pull request Nov 9, 2020
Closed
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4238/

@afharo
Copy link
Member Author

afharo commented Nov 9, 2020

@elasticmachine merge upstream

@afharo
Copy link
Member Author

afharo commented Nov 9, 2020

jenkins, test this please

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4238/

cchaos
cchaos approved these changes Nov 9, 2020
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thanks for the PR @afharo! I double-checked this in Mac's VO and it does read the callout when it appears.

@afharo afharo merged commit ace700d into elastic:master Nov 9, 2020
@afharo afharo deleted the a11y/EuiForm-errors-EuiCallout branch November 9, 2020 16:57
@chandlerprall chandlerprall mentioned this pull request Nov 23, 2020
Closed
@chandlerprall chandlerprall mentioned this pull request Dec 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cchaos cchaos cchaos approved these changes

Assignees
No one assigned
Labels
accessibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@afharo @kibanamachine @cchaos