[EuiCodeEditor] Enable exiting with esc
for all modes
#3833
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3819, which highlighted an un-exit-able EuiCodeEditor when
enableLiveAutocompletion=true
.The problem stemmed from the
this.aceEditor.editor.completer
logic, which will always be present whenenableLiveAutocompletion=true
regardless of the actual presence of an autocomplete element. There is no other analog to discern a scenario where esc is hit and an autocomplete is open.The solution is the use the
react-ace
commands
interface, which does not execute when an autocomplete is open. The previousonAceKeydown
logic remains becausecommands
also do no execute in read-only mode.Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked in IE11 and Firefox- [ ] Props have proper autodocs- [ ] Added documentation