-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed bug in datagrid calcuate width #3789
fixed bug in datagrid calcuate width #3789
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
jenkins test this |
jenkins test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3789/ |
jenkins test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3789/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM, tested locally with a grid configuration that previously failed. Thanks @Tocknicsu !
Summary
This MR fixed #3781.
return Math.max(widthToFill / unsizedColumnCount, 100);
is already deal withwidthToFill is <= 0
case.Therefore, we only need to consider
unsizedColumnCount is 0
case.Checklist
[ ] Check against all themes for compatibility in both light and dark modes[ ] Checked in mobile[ ] Checked in IE11 and Firefox[ ] Props have proper autodocs[ ] Added documentation[ ] Checked Code Sandbox works for the any docs examples[ ] Added or updated jest tests[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes