-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add returnKey glyph to EuiIcon #3783
Conversation
Preview documentation changes for this PR: https://eui.elastic.co/pr_3783/ |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3783/ |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3783/ |
@chaos the design is now updated with what we discussed:
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3783/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Looks great. Thanks for making those small changes. Looks like you still have the return.js
file lingering, but other than that, 👍
Preview documentation changes for this PR: https://eui.elastic.co/pr_3783/ |
Summary
This PR adds a
returnKey
glyph to EuiIcon. The icon is a requirement for #3782. The main idea is to use it inside a badge to indicate users that they can press an enter key to perform an action.Design
Dark and light themes
Icon being used in a badge
Checklist
[ ] Checked in mobile[ ] Props have proper autodocs[ ] Added documentation[ ] Checked Code Sandbox works for the any docs examples[ ] Checked for breaking changes and labeled appropriately