-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SASS globals helper file #3691
SASS globals helper file #3691
Conversation
Preview documentation changes for this PR: https://eui.elastic.co/pr_3691/ |
2 similar comments
Preview documentation changes for this PR: https://eui.elastic.co/pr_3691/ |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3691/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Read through this and checked the code / compile. Safe to merge!
a76f1aa
to
7f4019b
Compare
Good thing I checked this in Kibana, I had multiple paths wrong. All good now! All 4 themes properly compile with the proper globals. |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3691/ |
SASS Globals
Consuming apps that want to use our invisibles have to import the functions, mixins, and variable index files separately because importing the
global_styles/index.scss
file comes with the reset and animations (non-invisibles) that would be repeated for each import.This is too much for the apps to remember, so I made a helper file for the default and Amsterdam themes.
Checklist
[ ] Checked in mobile[ ] Checked in IE11 and Firefox[ ] Props have proper autodocs[ ] Added documentation[ ] Checked Code Sandbox works for the any docs examples[ ] Added or updated jest tests[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes