-
Notifications
You must be signed in to change notification settings - Fork 829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EuiTablePagination: Adds data-test-subj to the EuiContextMenuItem #2778
EuiTablePagination: Adds data-test-subj to the EuiContextMenuItem #2778
Conversation
…uiTablePagination
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
Thanks for submitting this! We'd like The attribute here would be something like data-test-subj={`tablePagination-${itemsPerPageOption}-rows`} |
Needs an entry to CHANGELOG.md, but otherwise looks good. |
jenkins test this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM; pulled and tested locally
…astic#2778) * Adds data-test-subj to the EuiContextMenuItem component rendered in EuiTablePagination * Changes how the data-test-subj value is set * Adds CHANGELOG line
Summary
Closes #2762
Added
data-test-subj
to theEuiContextMenuItem
inEuiTablePagination
Checklist