Added package icon to glyph set #2378
Conversation
| @@ -0,0 +1,3 @@ | |||
| <svg viewBox="0 0 14 14.69652"> | |||
There was a problem hiding this comment.
Hmmm, it looks like maybe your optimizer optimized too much. The icon viewBoxes should always be 16x16.
There was a problem hiding this comment.
Woops thanks good catch. I was having issue getting this to work as a single path in Figma, so I brought it into illustrator. Must have happened there on export
|
Blah I just noticed I have some facet button commits in here from my last PR which got merged. Is that going to screw up anything? |
|
Doesn't look like it based on the Diff. |
|
And so long as you squash when merging. |
|
I'm having second thoughts... I've done 3 iterations of the icon with slightly different perspective. The one i'm currently using is in the center. I'm leaning towards the option on the right, which leaves a little more whitespace around the vertical slit detail . Thoughts?
|
|
It's really up to you, I think either would work. |
|
These look great... all options are good, I also vote #3 :) |
|
@hbharding is the shot in the description the latest? It looks like the top and bottom points are bleeding over a bit. |
|
Great thanks. Updated the icon. I'll merge once the checks complete |
|
@ryankeairns sorry i missed your comment before merging! The top/bottom does bleed into the area, but I noticed some of our other icons like
|
|
Generally speaking, we do work to have things align to full pixels where possible. Obviously diagonal lines do not, for example, so it imperfect. In this his case, the top and bottom should. For that matter, node should as well. This can be tracked and handled in a separate issue/PR. thanks! |
* added package.js + package.svg * added icon reference to icon.tsx and src-docs/.../icon.js * update package icon * updated changelog * fixed svg viewbox * update package icon * updated icon test snapshot
Summary
Created a
packageicon which will be used by the upcoming Integrations project as a placeholder for packages that don't have a 3rd party logo. This icon may be applicable for other use cases.Artboard alignment
Rendered
Checklist
- [ ] Checked in mobile- [ ] Checked in IE11 and Firefox- [ ] Props have proper autodocs- [ ] Checked for breaking changes and labeled appropriately- [ ] Checked for accessibility including keyboard-only and screenreader modes