Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make EuiTableRowCell textOnly={false} when its an expanded row #2376

Merged
merged 2 commits into from
Sep 25, 2019
Merged

Make EuiTableRowCell textOnly={false} when its an expanded row #2376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc2565e
Make EuiTableRowCell textOnly={false} when its an expanded row
chandlerprall Sep 25, 2019
528f999
changelog
chandlerprall Sep 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
- Added a `showMaxPopover` option for `EuiBreadcrumbs` to display all items when a `max` is set. ([#2342](https://github.com/elastic/eui/pull/2342))
- Added `data-test-subj` support for basic and in-memory tables' actions ([#2353](https://github.com/elastic/eui/pull/2353))
- Added `ip` icon to glyph set ([#2371](https://github.com/elastic/eui/pull/2371))
- Set `textOnly={true}` for expanded rows in `EuiBasicTable` ([#2376](https://github.com/elastic/eui/pull/2376))

**Bug fixes**

Expand Down
1 change: 1 addition & 0 deletions src/components/basic_table/__snapshots__/basic_table.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1040,6 +1040,7 @@ exports[`EuiBasicTable itemIdToExpandedRowMap renders an expanded row 1`] = `
>
<EuiTableRowCell
colSpan={1}
textOnly={false}
>
<div>
Expanded row
Expand Down
2 changes: 1 addition & 1 deletion src/components/basic_table/basic_table.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -801,7 +801,7 @@ export class EuiBasicTable extends Component {
id={expandedRowId}
isExpandedRow={true}
isSelectable={isSelectable}>
<EuiTableRowCell colSpan={expandedRowColSpan}>
<EuiTableRowCell colSpan={expandedRowColSpan} textOnly={false}>
{itemIdToExpandedRowMap[itemId]}
</EuiTableRowCell>
</EuiTableRow>
Expand Down