Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added IP icon to glyph set #2371

Merged
merged 2 commits into from
Sep 25, 2019
Merged

Added IP icon to glyph set #2371

merged 2 commits into from
Sep 25, 2019

Conversation

cchaos
Copy link
Contributor

@cchaos cchaos commented Sep 24, 2019 •
edited
Loading

For use as a field type in Kibana

Artboard alignment

Screen Shot 2019-09-24 at 17 36 36 PM

Rendered

Screen Shot 2019-09-24 at 17 47 07 PM

Screen Shot 2019-09-24 at 17 47 12 PM

Checklist

  • Checked in dark mode
  • [ ] Checked in mobile
  • [ ] Checked in IE11 and Firefox
  • [ ] Props have proper autodocs
  • Added documentation examples
  • Added or updated jest tests
  • [ ] Checked for breaking changes and labeled appropriately
  • [ ] Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

ryankeairns
ryankeairns approved these changes Sep 25, 2019
View reviewed changes
Copy link
Contributor

@ryankeairns ryankeairns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cchaos cchaos merged commit a47bb81 into elastic:master Sep 25, 2019
@cchaos cchaos deleted the ip-icon branch September 25, 2019 16:33
@ryankeairns ryankeairns mentioned this pull request Sep 26, 2019
Merged
3 tasks
@cchaos cchaos mentioned this pull request Sep 27, 2019
Merged
snide pushed a commit to snide/eui that referenced this pull request Oct 10, 2019
@cchaos @snide
Added IP icon to glyph set (elastic#2371)
019c33b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryankeairns ryankeairns ryankeairns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cchaos @ryankeairns