Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply same top padding to EuiFormErrorText as EuiFormHelpText #2354

Merged
merged 2 commits into from
Sep 19, 2019

Conversation

cchaos
Copy link
Contributor

@cchaos cchaos commented Sep 19, 2019

Fixes #2352

Before
Screen Shot 2019-09-19 at 14 40 39 PM

After
Screen Shot 2019-09-19 at 14 40 45 PM

Checklist

  • [ ] Checked in dark mode
  • [ ] Checked in mobile
  • [ ] Checked in IE11 and Firefox
  • [ ] Props have proper autodocs
  • [ ] Added documentation examples
  • [ ] Added or updated jest tests
  • [ ] Checked for breaking changes and labeled appropriately
  • [ ] Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@cchaos cchaos changed the title Apply same top padding tp EuiFormErrorText as EuiFormHelpText Apply same top padding to EuiFormErrorText as EuiFormHelpText Sep 19, 2019
Copy link
Contributor

@andreadelrio andreadelrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cchaos cchaos merged commit 5346bcf into elastic:master Sep 19, 2019
@cchaos cchaos deleted the fix-help-text-spacing branch September 19, 2019 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EuiFormRow padding difference for helpText and error
2 participants