Form tests - Phase 2 #207
Merged
Form tests - Phase 2 #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcenizal
reviewed
Dec 14, 2017
| iconSide: PropTypes.oneOf(ICON_SIDES), | ||
| isLoading: PropTypes.bool, | ||
| className: PropTypes.string, |
| ICON_SIDES, | ||
| } from './form_control_layout'; | ||
|
|
||
| jest.mock('../../', () => ({ EuiIcon: 'eui_icon', EuiLoadingSpinner: 'eui_loading_spinner' })); |
There was a problem hiding this comment.
I'm learning a lot from your use of mocks.
| @@ -7,7 +7,9 @@ import { EuiFormErrorText } from './form_error_text'; | |||
| describe('EuiFormErrorText', () => { | |||
| test('is rendered', () => { | |||
| const component = render( | |||
| <EuiFormErrorText {...requiredProps} /> | |||
| <EuiFormErrorText {...requiredProps}> | |||
| <input/> | |||
There was a problem hiding this comment.
What do you think of just using text here instead of a node? The node validates that the prop supports this type, but text is much more demonstrative of an actual use case.
| @@ -7,7 +7,9 @@ import { EuiFormHelpText } from './form_help_text'; | |||
| describe('EuiFormHelpText', () => { | |||
| test('is rendered', () => { | |||
| const component = render( | |||
| <EuiFormHelpText {...requiredProps} /> | |||
| <EuiFormHelpText {...requiredProps}> | |||
| <input/> | |||
chrisronline
force-pushed
the
form-tests-p2
branch
from
b66146e
to
0d9642c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #177
Adds tests for: