-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiSuperDatePicker] Support onFocus
#4924
Comments
Hi, i would like to give this issue a shot |
@ConaGo Go for it! |
Hey, i implemented the change also added a test. Unfortunately this test will make another, seemingly unrelated test fail
` |
👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment. |
👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment. |
[EuiSuperDatePicker] Added code suggestions for onFocus (elastic#4924) Co-authored-by: Constance <constancecchen@users.noreply.github.com>
* [EuiSuperDatePicker] Support onFocus (#4924) * callback invoking multiple times. * [EuiSuperDatePicker] Updated the onFocus call on buttonProps and prettyDuration (#4924) * Apply suggestions from code review [EuiSuperDatePicker] Added code suggestions for onFocus (#4924) Co-authored-by: Constance <constancecchen@users.noreply.github.com> * [EuiSuperDatePicker] Updated super_date_picker's tests and onFocus on prettyFormat (#4924) * [EuiSuperDatePicker] added test case for focus on superDatePickerShowDatesButton (#4924) * [EuiSuperDatePicker] prettier error resolved (#4924) Co-authored-by: Constance <constancecchen@users.noreply.github.com>
👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment. |
❌ We're automatically closing this issue due to lack of activity. Please comment if you feel this was done in error. |
EuiSuperDatePicker should support
onFocus
. Given that there are multiple focusbale elements, the provided callback should likely only be called once on the initial element focus and not for each subcomponent focus event.The text was updated successfully, but these errors were encountered: