Update/fix cell popover Cypress tests

elastic · Nov 15, 2023 · 93fdea7 · 93fdea7
1 parent b0f2396
commit 93fdea7
Showing 1 changed file with 16 additions and 21 deletions.
diff --git a/src/components/datagrid/body/data_grid_cell_popover.spec.tsx b/src/components/datagrid/body/data_grid_cell_popover.spec.tsx
@@ -53,7 +53,7 @@ describe('EuiDataGridCellPopover', () => {
         '[data-gridcell-row-index="0"][data-gridcell-column-index="0"]'
       ).realClick();
 
-      cy.get('[data-test-subj="euiDataGridCellExpandButton"]').realClick();
+      cy.get('[data-test-subj="euiDataGridCellExpandButton"]').click();
       cy.focused().should(
         'have.attr',
         'data-test-subj',
@@ -73,7 +73,7 @@ describe('EuiDataGridCellPopover', () => {
         '[data-gridcell-row-index="1"][data-gridcell-column-index="1"]'
       ).realClick();
 
-      cy.get('[data-test-subj="euiDataGridCellExpandButton"]').realClick();
+      cy.get('[data-test-subj="euiDataGridCellExpandButton"]').click();
       cy.focused().should(
         'have.attr',
         'data-test-subj',
@@ -93,12 +93,12 @@ describe('EuiDataGridCellPopover', () => {
       '[data-gridcell-row-index="0"][data-gridcell-column-index="0"]'
     ).realClick();
 
-    cy.get('[data-test-subj="euiDataGridCellExpandButton"]').realClick();
+    cy.get('[data-test-subj="euiDataGridCellExpandButton"]').click();
     cy.get('[data-test-subj="euiDataGridExpansionPopover"]').should('exist');
 
     cy.get(
       '[data-gridcell-row-index="0"][data-gridcell-column-index="0"]'
-    ).realClick();
+    ).realClick({ position: 'right' });
     cy.get('[data-test-subj="euiDataGridExpansionPopover"]').should(
       'not.exist'
     );
@@ -126,7 +126,7 @@ describe('EuiDataGridCellPopover', () => {
     cy.get(
       '[data-gridcell-row-index="0"][data-gridcell-column-index="0"]'
     ).realClick();
-    cy.get('[data-test-subj="euiDataGridCellExpandButton"]').realClick();
+    cy.get('[data-test-subj="euiDataGridCellExpandButton"]').click();
 
     cy.get('.euiDataGridRowCell__popover.hello.world').should('exist');
   });
@@ -147,7 +147,7 @@ describe('EuiDataGridCellPopover', () => {
     const openCellPopover = (id: string) => {
       cy.get(
         `[data-gridcell-row-index="0"][data-gridcell-column-id="${id}"]`
-      ).realClick();
+      ).click();
       cy.realPress('Enter');
     };
 
@@ -156,9 +156,8 @@ describe('EuiDataGridCellPopover', () => {
 
       openCellPopover('B');
       cy.get('[data-test-subj="euiDataGridExpansionPopover"]')
-        .should('have.css', 'left', '24.5px')
-        .should('have.css', 'top')
-        .and('match', /^(104|103)px/); // CI is off by 1 px
+        .should('have.css', 'left', '109px')
+        .should('have.css', 'top', '73px');
     });
 
     it('lineCount row height', () => {
@@ -171,9 +170,8 @@ describe('EuiDataGridCellPopover', () => {
       openCellPopover('B');
 
       cy.get('[data-test-subj="euiDataGridExpansionPopover"]')
-        .should('have.css', 'left', '24.5px')
-        .should('have.css', 'top')
-        .and('match', /^(127|126)px/); // CI is off by 1 px
+        .should('have.css', 'left', '109px')
+        .should('have.css', 'top', '73px');
     });
 
     it('numerical row height', () => {
@@ -184,9 +182,8 @@ describe('EuiDataGridCellPopover', () => {
 
       // Should not be anchored to the bottom of the overflowing text
       cy.get('[data-test-subj="euiDataGridExpansionPopover"]')
-        .should('have.css', 'left', '24.5px')
-        .should('have.css', 'top')
-        .and('match', /^(106|105)px/); // CI is off by 1 px
+        .should('have.css', 'left', '109px')
+        .should('have.css', 'top', '73px');
     });
 
     it('auto row height', () => {
@@ -196,16 +193,14 @@ describe('EuiDataGridCellPopover', () => {
 
       openCellPopover('B');
       cy.get('[data-test-subj="euiDataGridExpansionPopover"]')
-        .should('have.css', 'left', '24.5px')
-        .should('have.css', 'top')
-        .and('match', /^(151|150)px/); // CI is off by 1 px
+        .should('have.css', 'left', '109px')
+        .should('have.css', 'top', '73px');
 
       // The shorter cell content should not have the same top position
       openCellPopover('A');
       cy.get('[data-test-subj="euiDataGridExpansionPopover"]')
-        .should('have.css', 'left', '19px')
-        .should('have.css', 'top')
-        .and('match', /^(103|102)px/); // CI is off by 1 px
+        .should('have.css', 'left', '109px')
+        .should('have.css', 'top', '73px');
     });
   });
 });