[PR feedback] Restore TEXT_SIZES

elastic · Apr 26, 2022 · 882da2a · 882da2a
1 parent 9244401
commit 882da2a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/components/health/health.test.tsx b/src/components/health/health.test.tsx
@@ -11,7 +11,7 @@ import { render } from 'enzyme';
 import { requiredProps } from '../../test/required_props';
 import { shouldRenderCustomStyles } from '../../test/internal';
 import { COLORS } from '../icon/icon';
-import { EuiHealth } from './health';
+import { EuiHealth, TEXT_SIZES } from './health';
 
 describe('EuiHealth', () => {
   test('is rendered', () => {
@@ -24,7 +24,7 @@ describe('EuiHealth', () => {
 
   describe('props', () => {
     describe('textSize', () => {
-      ['xs', 's', 'm', 'inherit'].forEach((textSize: any) => {
+      TEXT_SIZES.forEach((textSize: any) => {
         test(`${textSize} is rendered`, () => {
           const component = render(
             <EuiHealth textSize={textSize} color="success" />

diff --git a/src/components/health/health.tsx b/src/components/health/health.tsx
@@ -15,6 +15,8 @@ import { CommonProps } from '../common';
 import { EuiIcon, IconColor } from '../icon';
 import { EuiFlexGroup, EuiFlexItem } from '../flex';
 
+export const TEXT_SIZES = ['xs', 's', 'm', 'inherit'] as const;
+
 export type EuiHealthProps = CommonProps &
   Omit<HTMLAttributes<HTMLDivElement>, 'color'> & {
     /**
@@ -27,7 +29,7 @@ export type EuiHealthProps = CommonProps &
      * Matches the text scales of EuiText.
      * The `inherit` style will get its font size from the parent element
      */
-    textSize?: 'xs' | 's' | 'm' | 'inherit';
+    textSize?: typeof TEXT_SIZES[number];
   };
 
 export const EuiHealth: FunctionComponent<EuiHealthProps> = ({