[docs] Fix EuiBasicTable/EuiInMemoryTable props tabs not correctly lo…

…ading `@default`s
elastic · Jul 26, 2023 · 22964d2 · 22964d2
1 parent 0a18b85
commit 22964d2
Show file tree

Hide file tree

Showing 10 changed files with 20 additions and 8 deletions.
diff --git a/src-docs/src/views/tables/basic/basic_section.js b/src-docs/src/views/tables/basic/basic_section.js
@@ -7,7 +7,7 @@ import {
   Criteria,
   CriteriaWithPagination,
 } from '!!prop-loader!../../../../../src/components/basic_table/basic_table';
-import { Pagination } from '!!prop-loader!../../../../../src/components/basic_table/pagination_bar';
+import { Pagination } from '../paginated/_props';
 import {
   EuiTableFieldDataColumnType,
   EuiTableComputedColumnType,

diff --git a/src-docs/src/views/tables/in_memory/in_memory_controlled_pagination_section.js b/src-docs/src/views/tables/in_memory/in_memory_controlled_pagination_section.js
@@ -9,7 +9,7 @@ import {
   Criteria,
   CriteriaWithPagination,
 } from '!!prop-loader!../../../../../src/components/basic_table/basic_table';
-import { Pagination } from '!!prop-loader!../../../../../src/components/basic_table/pagination_bar';
+import { Pagination } from '../paginated/_props';
 import {
   EuiTableFieldDataColumnType,
   EuiTableComputedColumnType,

diff --git a/src-docs/src/views/tables/in_memory/in_memory_custom_sorting_section.js b/src-docs/src/views/tables/in_memory/in_memory_custom_sorting_section.js
@@ -9,7 +9,7 @@ import {
   Criteria,
   CriteriaWithPagination,
 } from '!!prop-loader!../../../../../src/components/basic_table/basic_table';
-import { Pagination } from '!!prop-loader!../../../../../src/components/basic_table/pagination_bar';
+import { Pagination } from '../paginated/_props';
 import {
   EuiTableFieldDataColumnType,
   EuiTableComputedColumnType,

diff --git a/src-docs/src/views/tables/in_memory/in_memory_search_callback_section.js b/src-docs/src/views/tables/in_memory/in_memory_search_callback_section.js
@@ -8,7 +8,7 @@ import {
   Criteria,
   CriteriaWithPagination,
 } from '!!prop-loader!../../../../../src/components/basic_table/basic_table';
-import { Pagination } from '!!prop-loader!../../../../../src/components/basic_table/pagination_bar';
+import { Pagination } from '../paginated/_props';
 import {
   EuiTableFieldDataColumnType,
   EuiTableComputedColumnType,

diff --git a/src-docs/src/views/tables/in_memory/in_memory_search_external_section.js b/src-docs/src/views/tables/in_memory/in_memory_search_external_section.js
@@ -8,7 +8,7 @@ import {
   Criteria,
   CriteriaWithPagination,
 } from '!!prop-loader!../../../../../src/components/basic_table/basic_table';
-import { Pagination } from '!!prop-loader!../../../../../src/components/basic_table/pagination_bar';
+import { Pagination } from '../paginated/_props';
 import {
   EuiTableFieldDataColumnType,
   EuiTableComputedColumnType,

diff --git a/src-docs/src/views/tables/in_memory/in_memory_search_section.js b/src-docs/src/views/tables/in_memory/in_memory_search_section.js
@@ -9,7 +9,7 @@ import {
   Criteria,
   CriteriaWithPagination,
 } from '!!prop-loader!../../../../../src/components/basic_table/basic_table';
-import { Pagination } from '!!prop-loader!../../../../../src/components/basic_table/pagination_bar';
+import { Pagination } from '../paginated/_props';
 import {
   EuiTableFieldDataColumnType,
   EuiTableComputedColumnType,

diff --git a/src-docs/src/views/tables/in_memory/in_memory_section.js b/src-docs/src/views/tables/in_memory/in_memory_section.js
@@ -9,7 +9,7 @@ import {
   Criteria,
   CriteriaWithPagination,
 } from '!!prop-loader!../../../../../src/components/basic_table/basic_table';
-import { Pagination } from '!!prop-loader!../../../../../src/components/basic_table/pagination_bar';
+import { Pagination } from '../paginated/_props';
 import {
   EuiTableFieldDataColumnType,
   EuiTableComputedColumnType,

diff --git a/src-docs/src/views/tables/in_memory/in_memory_selection_section.js b/src-docs/src/views/tables/in_memory/in_memory_selection_section.js
@@ -8,7 +8,7 @@ import {
   Criteria,
   CriteriaWithPagination,
 } from '!!prop-loader!../../../../../src/components/basic_table/basic_table';
-import { Pagination } from '!!prop-loader!../../../../../src/components/basic_table/pagination_bar';
+import { Pagination } from '../paginated/_props';
 import {
   EuiTableFieldDataColumnType,
   EuiTableComputedColumnType,

diff --git a/src-docs/src/views/tables/paginated/_props.tsx b/src-docs/src/views/tables/paginated/_props.tsx
@@ -0,0 +1,6 @@
+import React, { FunctionComponent } from 'react';
+
+import { Pagination as _Pagination } from '../../../../../src/components/basic_table/pagination_bar';
+
+// Loading `Pagination` directly via !prop-loader doesn't correctly inherit @defaults
+export const Pagination: FunctionComponent<_Pagination> = () => <div />;
diff --git a/src/components/basic_table/in_memory_table.tsx b/src/components/basic_table/in_memory_table.tsx
@@ -76,7 +76,13 @@ type InMemoryTableProps<T> = Omit<
    * Configures #Search.
    */
   search?: Search;
+  /**
+   * Configures #Pagination
+   */
   pagination?: undefined;
+  /**
+   * Configures #EuiTableSortingType
+   */
   sorting?: Sorting;
   /**
    * Set `allowNeutralSort` to false to force column sorting. Defaults to true.