Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS]Fix bulk request comment grammar issue. #95247

Merged
merged 1 commit into from
Apr 17, 2023
Merged

[DOCS]Fix bulk request comment grammar issue. #95247

merged 1 commit into from
Apr 17, 2023

Conversation

howardhuanghua
Copy link
Contributor

Fix bulk request comment grammar issue.

@elasticsearchmachine
Copy link
Collaborator

@howardhuanghua please enable the option "Allow edits and access to secrets by maintainers" on your PR. For more information, see the documentation.

@elasticsearchmachine elasticsearchmachine added v8.8.0 needs:triage Requires assignment of a team area label external-contributor Pull request authored by a developer outside the Elasticsearch team labels Apr 14, 2023
@HiDAl
Copy link
Contributor

HiDAl commented Apr 17, 2023

@elasticmachine test this please

@HiDAl HiDAl added >docs General docs changes and removed needs:triage Requires assignment of a team area label labels Apr 17, 2023
@elasticsearchmachine elasticsearchmachine added the Team:Docs Meta label for docs team label Apr 17, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@HiDAl HiDAl self-assigned this Apr 17, 2023
@HiDAl
Copy link
Contributor

HiDAl commented Apr 17, 2023

@howardhuanghua can you follow the guideline from this message? thanks

@HiDAl HiDAl self-requested a review April 17, 2023 10:31
@howardhuanghua
Copy link
Contributor Author

howardhuanghua commented Apr 17, 2023 •
edited
Loading

@howardhuanghua can you follow the guideline from this message? thanks

Hi @HiDAl , it seems I don't have the option in my own forked repository. Any enhancement I can do it directly?

@HiDAl
Copy link
Contributor

HiDAl commented Apr 17, 2023

thanks @howardhuanghua !

@HiDAl HiDAl merged commit bf604c9 into elastic:main Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HiDAl HiDAl HiDAl approved these changes

Assignees

@HiDAl HiDAl

Labels
>docs General docs changes external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Docs Meta label for docs team v8.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@howardhuanghua @elasticsearchmachine @HiDAl