Remove allocations and copying from writing translog ops to the network #95048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no reason to prefix ops with their size over the network. We can verify the checksum once after reading each op and just streaming write ops.
original-brownbear
added
>non-issue
:Distributed Indexing/Engine
elasticsearchmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
| @@ -1159,9 +1158,6 @@ private Index(final StreamInput in) throws IOException { | |||
| } | |||
| source = in.readBytesReference(); | |||
| routing = in.readOptionalString(); | |||
| if (format < FORMAT_NO_PARENT) { | |||
There was a problem hiding this comment.
Removing this old dead code here since it's not worth a separate PR, we never set the format variable to something before the no parent format these days.
DaveCTurner
approved these changes
Apr 5, 2023
There was a problem hiding this comment.
Neat, LGTM. We originally added these length-prefixes in reaction to some Jepsen failures in 1.x (#10933 (comment)) when I suspect this code was used to write ops to disk as well as over the wire.
|
Thanks David! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this while going through some of the translog code, this should soften the heap blow from very large documents a little ...
There's no reason to prefix ops with their size over the network. We can verify the checksum once after reading each op and just streaming write ops.