Optionally disable TLS in RCS tests #94938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n1v0lg
added
>test
n1v0lg
commented
Mar 31, 2023
| * This is needed because `randomBoolean` is not available inside the outer `static {}` scope, | ||
| * where the initial cluster settings are set | ||
| */ | ||
| private static String atomicallyRandomizeSslEnabled(AtomicReference<Boolean> sslEnabledRef) { |
There was a problem hiding this comment.
I'm passing the atomic ref explicitly since it reads a little clearer to me this way where the "atomically" comes from. No strong preference though, can also inline.
n1v0lg
commented
Mar 31, 2023
| @@ -84,6 +85,17 @@ public class RemoteClusterSecurityRestIT extends AbstractRemoteClusterSecurityTe | |||
| .build(); | |||
| } | |||
|
|
|||
| /** | |||
| * This is needed because `randomBoolean` is not available inside the outer `static {}` scope, | |||
There was a problem hiding this comment.
A quirk here: using randomBoolean() in the static {} block results in a classMethod exception:
No context information for thread: Thread[id=32, name=SUITE-RemoteClusterSecurityRestIT-seed#[85BC9D463CA78D4], state=RUNNABLE, group=TGRP-RemoteClusterSecurityRestIT]. Is this thread running under a class com.carrotsearch.randomizedtesting.RandomizedRunner runner context? Add @RunWith(class com.carrotsearch.randomizedtesting.RandomizedRunner.class) to your test class. Make sure your code accesses random contexts within @BeforeClass and @AfterClass boundary (for example, static test class initializers are not permitted to access random contexts).
java.lang.IllegalStateException: No context information for thread: Thread[id=32, name=SUITE-RemoteClusterSecurityRestIT-seed#[85BC9D463CA78D4], state=RUNNABLE, group=TGRP-RemoteClusterSecurityRestIT]. Is this thread running under a class com.carrotsearch.randomizedtesting.RandomizedRunner runner context? Add @RunWith(class com.carrotsearch.randomizedtesting.RandomizedRunner.class) to your test class. Make sure your code accesses random contexts within @BeforeClass and @AfterClass boundary (for example, static test class initializers are not permitted to access random contexts).
at com.carrotsearch.randomizedtesting.RandomizedContext.context(RandomizedContext.java:249)
at com.carrotsearch.randomizedtesting.RandomizedContext.current(RandomizedContext.java:134)
at org.apache.lucene.tests.util.LuceneTestCase.random(LuceneTestCase.java:792)
at org.elasticsearch.test.ESTestCase.randomBoolean(ESTestCase.java:775)
at org.elasticsearch.xpack.remotecluster.RemoteClusterSecurityRestIT.<clinit>(RemoteClusterSecurityRestIT.java:49)
at java.base/java.lang.Class.forName0(Native Method)
at java.base/java.lang.Class.forName(Class.java:496)
at java.base/java.lang.Class.forName(Class.java:475)
at com.carrotsearch.randomizedtesting.RandomizedRunner$2.run(RandomizedRunner.java:631)
"for example, static test class initializers are not permitted to access random contexts" explains this.
We could probably come up with a cleaner workaround but that requires some work. I think my hack is sufficient for now.
|
Pinging @elastic/es-security (Team:Security) |
ywangd
approved these changes
Mar 31, 2023
...src/javaRestTest/java/org/elasticsearch/xpack/remotecluster/RemoteClusterSecurityRestIT.java
Outdated
Show resolved
Hide resolved
...src/javaRestTest/java/org/elasticsearch/xpack/remotecluster/RemoteClusterSecurityRestIT.java
Outdated
Show resolved
Hide resolved
|
@elasticmachine update branch |
n1v0lg
added
the
auto-merge-without-approval
|
@elasticmachine update branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More test coverage.