Adding initial public and internal serverless scopes to Core-Infra REST handlers #94037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
needs:triage
masseyke
added
:Core/Infra/REST API
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
rjernst
approved these changes
Apr 14, 2023
| import org.elasticsearch.rest.action.RestToXContentListener; | ||
|
|
||
| import java.io.IOException; | ||
| import java.util.List; | ||
|
|
||
| import static org.elasticsearch.rest.RestRequest.Method.GET; | ||
|
|
||
| @ServerlessScope(Scope.PUBLIC) |
There was a problem hiding this comment.
Can you please remove this one from the PR? We are still in discussions about whether it is necessary (and there are actually 2 versions of this API under different paths).
| import org.elasticsearch.rest.action.RestToXContentListener; | ||
|
|
||
| import java.io.IOException; | ||
| import java.util.List; | ||
|
|
||
| import static org.elasticsearch.rest.RestRequest.Method.GET; | ||
|
|
||
| @ServerlessScope(Scope.PUBLIC) |
There was a problem hiding this comment.
Can you please remove this one from the PR? We are still in discussions about whether it is necessary (and there are actually 2 versions of this API under different paths).
masseyke
added
the
auto-merge-without-approval
|
@elasticmachine update branch |
pgomulka
added a commit
to pgomulka/elasticsearch
that referenced
this pull request
Apr 20, 2023
This commit exposes core/infra owned REST APIs for serverless deployment It uses @ServerlessScope(Scope.PUBLIC) to achieve this. relates elastic#94037
pgomulka
added a commit
that referenced
this pull request
Apr 21, 2023
This commit exposes core/infra owned REST APIs for serverless deployment. It uses @ServerlessScope(Scope.PUBLIC) to achieve this. follows up on #94037
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#93607 added the ability to run Elasticsearch in "Serverless" mode, where access to REST endpoints could be restricted so that the full Elasticsearch API is not available (since a lot of it does not make sense in Servlerless). By default no endpoints are available, but they can be exposed with
ServerlessScopeannotations.This PR follows up on #93607 by adding PUBLIC and INTERNAL annotations to the rest handlers owned by the Core Infra team. There are several rest endpoints still under discussion. This PR does not label those, so they remain unavailable in Serverless mode.