Add log level for JVM logs #92382
Merged
Add log level for JVM logs #92382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we specify `level` in JVM logs. `level` helps to filter more severe messages from mere debugging messages in logs and with this change we are able to use it also for JVM logs. Here are a few example lines: Before: ``` [2022-12-15T06:19:16.936+0000][15181][gc,start ] GC(0) Pause Young (Normal) (G1 Evacuation Pause) ``` After: ``` [2022-12-15T06:22:27.932+0000][16320][info][gc,start ] GC(0) Pause Young (Normal) (G1 Evacuation Pause) [2022-12-15T06:22:27.932+0000][16320][debug][gc,age ] GC(0) Desired survivor size 14680064 bytes, new threshold 15 (max threshold 15) [2022-12-15T06:22:27.935+0000][16320][info ][gc,phases ] GC(0) Pre Evacuate Collection Set: 0.1ms [2022-12-15T06:22:27.935+0000][16320][trace][gc,age ] GC(0) Age table with threshold 15 (max threshold 15) ``` Notice, that the log level might have trailing spaces. See also https://docs.oracle.com/en/java/javase/19/docs/specs/man/java.html#xlog-tags-and-levels for the available log levels.
danielmitterdorfer
added
>enhancement
:Core/Infra/Core
|
Documentation preview: |
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
|
Hi @danielmitterdorfer, I've created a changelog YAML for you. |
|
Some more notes:
|
danielmitterdorfer
added a commit
to danielmitterdorfer/beats
that referenced
this pull request
Jan 3, 2023
Elasticsearch will add a log level to its JVM logs to allow users to help them detect errors / warnings more easily. With this commit we detect this new field if present and continue to recognize the prior log format without a log level. Relates elastic/elasticsearch#92382 Closes elastic#34054
6 tasks
|
Thanks for the review! Just fyi: I'm waiting to merge this PR until elastic/beats#34159 is merged so Beats can recognize the new field. |
leehinman
pushed a commit
to elastic/beats
that referenced
this pull request
Jan 9, 2023
* Recognize log level in Elasticsearch JVM logs Elasticsearch will add a log level to its JVM logs to allow users to help them detect errors / warnings more easily. With this commit we detect this new field if present and continue to recognize the prior log format without a log level. Relates elastic/elasticsearch#92382 Closes #34054
4 tasks
chrisberkhout
pushed a commit
to elastic/beats
that referenced
this pull request
Jun 1, 2023
* Recognize log level in Elasticsearch JVM logs Elasticsearch will add a log level to its JVM logs to allow users to help them detect errors / warnings more easily. With this commit we detect this new field if present and continue to recognize the prior log format without a log level. Relates elastic/elasticsearch#92382 Closes #34054
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we specify
levelin JVM logs.levelhelps to filter more severe messages from mere debugging messages in logs and with this change we are able to use it also for JVM logs.Here are a few example lines:
Before:
After:
Notice how the log level might have trailing spaces.
See also
https://docs.oracle.com/en/java/javase/19/docs/specs/man/java.html#xlog-tags-and-levels for the available log levels.