ILM don't rollover empty indices #89557
Conversation
so the String and Setting versions are in the same order, likewise the IndexLifecycle list of settings..
so that everything handling the conditions is last
This is controlled via the cluster-wide indices.lifecycle.rollover.only_if_has_documents setting, and will only apply if the policy doesn't already have an explicit min_docs (or min_primary_shard_docs) condition. That is, to disable this behavior globally, use the setting; but to disable it on a per-policy basis, add an explicit min_docs: 0 condition.
joegallo
added
>enhancement
:Data Management/ILM+SLM
|
Hi @joegallo, I've created a changelog YAML for you. |
|
Hi @joegallo, I've updated the changelog YAML for you. Note that since this PR is labelled |
set min_docs to 0 so this test policy will rollover
|
Pinging @elastic/es-data-management (Team:Data Management) |
| ); | ||
| } | ||
|
|
||
| // visible for testing |
There was a problem hiding this comment.
I'd be even better if this had javadoc, even though it's essentially private :)
| assertTrue(indexExists(originalIndex)); | ||
| }, 30, TimeUnit.SECONDS); | ||
|
|
||
| switch (between(0, 2)) { |
There was a problem hiding this comment.
I think rather than randomize between the three potential ways to force a rollover, I'd rather explicitly do each of them. This would allow us to catch issues better in the future that might only break one of the branches since we don't test each method every CI run.
There was a problem hiding this comment.
Good suggestion, on it.
Closes #86203, related to #89283
ILM will no longer roll over empty indices by default. This is accomplished by injecting a
min_docs: 1condition into the rollover dry run request inWaitForRolloverReadyStep.Such a condition will only be injected if there's not already a
min_docs(ormin_primary_shard_docs) condition associated with the rollover, so a policy can opt out of the new behavior by adding an explicitmin_docs: 0condition to the rollover action.This can also be disabled on a cluster-wide basis by setting
indices.lifecycle.rollover.only_if_has_documentstofalse.