Refactor json parsing in immutable handlers #88492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grcevski
added
>non-issue
:Core/Infra/Core
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
grcevski
commented
Jul 13, 2022
| @@ -284,18 +284,4 @@ static int capacity(int expectedSize) { | |||
| return expectedSize < 2 ? expectedSize + 1 : (int) (expectedSize / 0.75 + 1.0); | |||
| } | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
Not needed anymore with the way I do parsing. This method was added previously by me.
grcevski
commented
Jul 13, 2022
| @@ -0,0 +1,8 @@ | |||
| # | |||
There was a problem hiding this comment.
I added this file because we need it to expose the service provider when we load them in the future using PluginsService createExtension.
ChrisHegarty
approved these changes
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current immutable handlers assume json input, which is inefficient for use by plugins and modules. This PR refactors the xcontent parsing in a separate method to be used only when we actually have json input (file based settings).
This way the immutable state controller can work with POJOs and xcontent too.
This PR is split off from #88224 to reduce the PR size.