-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Azul Zulu JDK8 distribution instead of Adoptium/OpenJDK on MacOS with Apple Silicon #87733
Merged
mark-vieira
merged 3 commits into
elastic:master
from
ap-kulkarni:ap-kulka/jdk8-macos-aarch64
Jun 22, 2022
Merged
Use Azul Zulu JDK8 distribution instead of Adoptium/OpenJDK on MacOS with Apple Silicon #87733
mark-vieira
merged 3 commits into
elastic:master
from
ap-kulkarni:ap-kulka/jdk8-macos-aarch64
Jun 22, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with Apple Silicon.
elasticsearchmachine
added
v8.4.0
external-contributor
Pull request authored by a developer outside the Elasticsearch team
labels
Jun 16, 2022
Pinging @elastic/es-delivery (Team:Delivery) |
@elasticmachine ok to test |
@ap-kulkarni can you address the failures in |
Sure.. I'll look into the failures. Thank you. |
mark-vieira
approved these changes
Jun 22, 2022
Everything looks good. Thanks for the contribution @ap-kulkarni! |
💔 Backport failed
You can use sqren/backport to manually backport by running |
mark-vieira
pushed a commit
to mark-vieira/elasticsearch
that referenced
this pull request
Jun 22, 2022
…with Apple Silicon (elastic#87733)
mark-vieira
pushed a commit
to mark-vieira/elasticsearch
that referenced
this pull request
Jun 22, 2022
…with Apple Silicon (elastic#87733) # Conflicts: # x-pack/qa/repository-old-versions/build.gradle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Delivery/Build
Build or test infrastructure
external-contributor
Pull request authored by a developer outside the Elasticsearch team
>non-issue
Team:Delivery
Meta label for Delivery team
v7.17.5
v8.3.0
v8.4.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On MacOS with apple silicon,
gradle check
and gradle builds fail since adoptium/openjdk do not provide jdk 8 distributions for macos arm64 version. JDK8 is required in tasksmodules:reindex:oldEs1Fixture
andx-pack:qa:repository-old-versions
. These changes will make use of the zulu distribution which provides a jdk8 version for macos arm64 and let the build tasks proceed successfully on Apple Silicon (M1/M2 processors) machines.gradle check
?