Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Azul Zulu JDK8 distribution instead of Adoptium/OpenJDK on MacOS with Apple Silicon #87733

Merged
merged 3 commits into from
Jun 22, 2022
Merged

Use Azul Zulu JDK8 distribution instead of Adoptium/OpenJDK on MacOS with Apple Silicon #87733

merged 3 commits into from
Jun 22, 2022

Conversation

ap-kulkarni
Copy link
Contributor

On MacOS with apple silicon, gradle check and gradle builds fail since adoptium/openjdk do not provide jdk 8 distributions for macos arm64 version. JDK8 is required in tasks modules:reindex:oldEs1Fixture and x-pack:qa:repository-old-versions. These changes will make use of the zulu distribution which provides a jdk8 version for macos arm64 and let the build tasks proceed successfully on Apple Silicon (M1/M2 processors) machines.

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS and architecture that we support?
  • If you are submitting this code for a class then read our policy for that.

@elasticsearchmachine elasticsearchmachine added v8.4.0 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Jun 16, 2022
@DJRickyB DJRickyB added the :Delivery/Build Build or test infrastructure label Jun 16, 2022
@elasticmachine elasticmachine added the Team:Delivery Meta label for Delivery team label Jun 16, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

@mark-vieira
Copy link
Contributor

@elasticmachine ok to test

@mark-vieira
Copy link
Contributor

@ap-kulkarni can you address the failures in JdkDownloadPluginTests related to these changes?

@ap-kulkarni
Copy link
Contributor Author

Sure.. I'll look into the failures. Thank you.

@mark-vieira
Copy link
Contributor

Everything looks good. Thanks for the contribution @ap-kulkarni!

@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
8.3
7.17 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 87733

mark-vieira pushed a commit to mark-vieira/elasticsearch that referenced this pull request Jun 22, 2022
mark-vieira pushed a commit to mark-vieira/elasticsearch that referenced this pull request Jun 22, 2022
…with Apple Silicon (elastic#87733)

# Conflicts:
#	x-pack/qa/repository-old-versions/build.gradle
elasticsearchmachine pushed a commit that referenced this pull request Jun 22, 2022
…with Apple Silicon (#87733) (#87935)

# Conflicts:
#	x-pack/qa/repository-old-versions/build.gradle

Co-authored-by: Amey Kulkarni <ameykulkarni@live.in>
elasticsearchmachine pushed a commit that referenced this pull request Jun 22, 2022
…with Apple Silicon (#87733) (#87934)

Co-authored-by: Amey Kulkarni <ameykulkarni@live.in>
@ap-kulkarni ap-kulkarni deleted the ap-kulka/jdk8-macos-aarch64 branch July 14, 2022 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Delivery/Build Build or test infrastructure external-contributor Pull request authored by a developer outside the Elasticsearch team >non-issue Team:Delivery Meta label for Delivery team v7.17.5 v8.3.0 v8.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants