Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle fields.with.dots in routing_path #83148

Merged
merged 7 commits into from
Feb 2, 2022

Commits on Jan 26, 2022

  1. Handle fields.with.dots in routing_path

    Our document parsing code treats:
    ```
    {"foo.bar": "baz"}
    ```
    the same as:
    ```
    {"foo": {"bar": "baz"}}
    ```
    but the code that extracted routing_path didn't! This is bad because
    routing_path has to identify a subset of dimensions precisely and in the
    same way that our mapping code identifies the dimensions. They have to
    line up or two time series could end up on different shards. Sad times.
    
    This makes `routing_path` interpret dots in field names as though they
    were an object. It creates an option for the includes/excludes filters
    on `XContentParser` to treats dots as objects. So the filter would see
    ```
    {"foo.bar": "baz"}
    ```
    as though it were:
    ```
    {"foo": {"bar": "baz"}}
    ```
    
    So the filter `foo.bar` would match both documents.
    
    This is part of elastic#82511.
    nik9000 committed Jan 26, 2022
    Configuration menu
    Copy the full SHA
    b1aee0d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ffd45bb View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7b8ac33 View commit details
    Browse the repository at this point in the history
  4. Add changelog area

    nik9000 committed Jan 26, 2022
    Configuration menu
    Copy the full SHA
    9d09c92 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2022

  1. Configuration menu
    Copy the full SHA
    ee586f8 View commit details
    Browse the repository at this point in the history
  2. Don't need this one any more

    nik9000 committed Jan 28, 2022
    Configuration menu
    Copy the full SHA
    96809fd View commit details
    Browse the repository at this point in the history
  3. Dupe

    nik9000 committed Jan 28, 2022
    Configuration menu
    Copy the full SHA
    fd51d75 View commit details
    Browse the repository at this point in the history