-
Notifications
You must be signed in to change notification settings - Fork 24.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix FLS for frozen tier #82521
Merged
Merged
Fix FLS for frozen tier #82521
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -38,6 +38,7 @@ | |
import org.elasticsearch.core.Tuple; | ||
import org.elasticsearch.index.mapper.FieldNamesFieldMapper; | ||
import org.elasticsearch.index.mapper.SourceFieldMapper; | ||
import org.elasticsearch.transport.Transports; | ||
import org.elasticsearch.xcontent.XContentBuilder; | ||
import org.elasticsearch.xcontent.XContentType; | ||
|
||
|
@@ -48,6 +49,7 @@ | |
import java.util.Iterator; | ||
import java.util.List; | ||
import java.util.Map; | ||
import java.util.Optional; | ||
|
||
/** | ||
* A {@link FilterLeafReader} that exposes only a subset | ||
|
@@ -122,7 +124,7 @@ public CacheHelper getReaderCacheHelper() { | |
/** An automaton that only accepts authorized fields. */ | ||
private final CharacterRunAutomaton filter; | ||
/** {@link Terms} cache with filtered stats for the {@link FieldNamesFieldMapper} field. */ | ||
private final Terms fieldNamesFilterTerms; | ||
private volatile Optional<Terms> fieldNamesFilterTerms; | ||
|
||
/** | ||
* Wrap a single segment, exposing a subset of its fields. | ||
|
@@ -137,8 +139,6 @@ public CacheHelper getReaderCacheHelper() { | |
} | ||
fieldInfos = new FieldInfos(filteredInfos.toArray(new FieldInfo[filteredInfos.size()])); | ||
this.filter = filter; | ||
final Terms fieldNameTerms = super.terms(FieldNamesFieldMapper.NAME); | ||
this.fieldNamesFilterTerms = fieldNameTerms == null ? null : new FieldNamesTerms(fieldNameTerms); | ||
} | ||
|
||
/** returns true if this field is allowed. */ | ||
|
@@ -432,7 +432,18 @@ private Terms wrapTerms(Terms terms, String field) throws IOException { | |
// for the _field_names field, fields for the document | ||
// are encoded as postings, where term is the field. | ||
// so we hide terms for fields we filter out. | ||
return fieldNamesFilterTerms; | ||
if (fieldNamesFilterTerms == null) { | ||
synchronized (this) { | ||
if (fieldNamesFilterTerms == null) { | ||
assert Transports.assertNotTransportThread("resolving filter terms"); | ||
final Terms fieldNameTerms = super.terms(FieldNamesFieldMapper.NAME); | ||
this.fieldNamesFilterTerms = Optional.ofNullable( | ||
fieldNameTerms == null ? null : new FieldNamesTerms(fieldNameTerms) | ||
); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: it feels a bit weird to use this.fieldNamesFilterTerms = fieldNameTerms == null ? Optional.empty() : Optional.of(new FieldNamesTerms(fieldNameTerms)); |
||
} | ||
} | ||
} | ||
return fieldNamesFilterTerms.orElse(null); | ||
} else { | ||
return terms; | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you leave a comment that explains why this is computed lazily?