Change Docker quickstart to only bind to localhost #80812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under the [wrong circumstances](https://twitter.com/gnyman/status/1441073513457233928) our quickstart will expose Elasticsearch and Kibana to the internet, which is rather surprising and what we avoid with our other defaults / setups. [Discussed](https://twitter.com/gnyman/status/1441119091645812742) [multiple](https://twitter.com/xeraa/status/1441164987049803787) [times](https://twitter.com/hmoffatt/status/1461067219647885315), we should explicitly bind to localhost to avoid such surprises. Those who know Docker reasonably well will be able to change it without problems and those who don't know Docker are probably better off like this. Since this has changed in 8.0, but we'll have 7.16 around for a long time, I've only committed the change to the 7.16 branch.
elasticsearchmachine
added
v7.16.1
external-contributor
pugnascotia
approved these changes
Nov 18, 2021
jrodewig
approved these changes
Nov 18, 2021
There was a problem hiding this comment.
Thanks @xeraa.
I also pushed 7149ba7 to update the run command in Stating a single node cluster with Docker. While this is also intended largely for test purposes, it can expose ES publicly.
I'll open a separate PR to update the Kibana instructions.
This LGTM.
jrodewig
added
:Delivery/Packaging
elasticmachine
added
Team:Delivery
|
Pinging @elastic/es-delivery (Team:Delivery) |
|
Pinging @elastic/es-docs (Team:Docs) |
This was referenced Nov 18, 2021
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 18, 2021
…80833) Under the [wrong circumstances](https://twitter.com/gnyman/status/1441073513457233928) our quickstart will expose Elasticsearch and Kibana to the internet, which is rather surprising and what we avoid with our other defaults / setups. [Discussed](https://twitter.com/gnyman/status/1441119091645812742) [multiple](https://twitter.com/xeraa/status/1441164987049803787) [times](https://twitter.com/hmoffatt/status/1461067219647885315), we should explicitly bind to localhost to avoid such surprises. Those who know Docker reasonably well will be able to change it without problems and those who don't know Docker are probably better off like this. Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com> Co-authored-by: Philipp Krenn <xeraa@users.noreply.github.com>
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 18, 2021
…80834) Under the [wrong circumstances](https://twitter.com/gnyman/status/1441073513457233928) our quickstart will expose Elasticsearch and Kibana to the internet, which is rather surprising and what we avoid with our other defaults / setups. [Discussed](https://twitter.com/gnyman/status/1441119091645812742) [multiple](https://twitter.com/xeraa/status/1441164987049803787) [times](https://twitter.com/hmoffatt/status/1461067219647885315), we should explicitly bind to localhost to avoid such surprises. Those who know Docker reasonably well will be able to change it without problems and those who don't know Docker are probably better off like this. Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com> Co-authored-by: Philipp Krenn <xeraa@users.noreply.github.com>
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 18, 2021
…80835) Under the [wrong circumstances](https://twitter.com/gnyman/status/1441073513457233928) our quickstart will expose Elasticsearch and Kibana to the internet, which is rather surprising and what we avoid with our other defaults / setups. [Discussed](https://twitter.com/gnyman/status/1441119091645812742) [multiple](https://twitter.com/xeraa/status/1441164987049803787) [times](https://twitter.com/hmoffatt/status/1461067219647885315), we should explicitly bind to localhost to avoid such surprises. Those who know Docker reasonably well will be able to change it without problems and those who don't know Docker are probably better off like this. Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com> Co-authored-by: Philipp Krenn <xeraa@users.noreply.github.com>
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 18, 2021
…80836) Under the [wrong circumstances](https://twitter.com/gnyman/status/1441073513457233928) our quickstart will expose Elasticsearch and Kibana to the internet, which is rather surprising and what we avoid with our other defaults / setups. [Discussed](https://twitter.com/gnyman/status/1441119091645812742) [multiple](https://twitter.com/xeraa/status/1441164987049803787) [times](https://twitter.com/hmoffatt/status/1461067219647885315), we should explicitly bind to localhost to avoid such surprises. Those who know Docker reasonably well will be able to change it without problems and those who don't know Docker are probably better off like this. Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com> Co-authored-by: Philipp Krenn <xeraa@users.noreply.github.com>
jrodewig
added a commit
to elastic/kibana
that referenced
this pull request
Nov 18, 2021
The current Docker run instructions can expose Kibana and Elasticsearch publicly to the internet. This updates the instructions to bind to localhost to avoid this. Relates to elastic/elasticsearch#80812
jrodewig
added a commit
to elastic/kibana
that referenced
this pull request
Nov 18, 2021
) The current Docker run instructions can expose Kibana and Elasticsearch publicly to the internet. This updates the instructions to bind to localhost to avoid this. Relates to elastic/elasticsearch#80812
jrodewig
added a commit
to elastic/kibana
that referenced
this pull request
Nov 18, 2021
) The current Docker run instructions can expose Kibana and Elasticsearch publicly to the internet. This updates the instructions to bind to localhost to avoid this. Relates to elastic/elasticsearch#80812
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under the wrong circumstances our quickstart will expose Elasticsearch and Kibana to the internet, which is rather surprising and what we avoid with our other defaults / setups.
Discussed multiple times, we should explicitly bind to localhost to avoid such surprises. Those who know Docker reasonably well will be able to change it without problems and those who don't know Docker are probably better off like this.
Since this has changed in 8.0, but we'll have 7.16 around for a long time, I've only committed the change to the 7.16 branch.