Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Document _mvt API #75384

Merged
merged 35 commits into from
Aug 5, 2021
Merged

[DOCS] Document _mvt API #75384

merged 35 commits into from
Aug 5, 2021

Conversation

jrodewig
Copy link
Contributor

@jrodewig jrodewig commented Jul 15, 2021

Documents the `_mvt` API endpoint added with #73872.

Relates to #75242.
@sethmlarson sethmlarson added the Team:Clients Meta label for clients team label Jul 15, 2021
@jrodewig jrodewig marked this pull request as ready for review July 15, 2021 17:44
@elasticmachine
Copy link
Collaborator

Pinging @elastic/clients-team (Team:Clients)

@jrodewig jrodewig added :Analytics/Geo Indexing, search aggregations of geo points and shapes >docs General docs changes labels Jul 15, 2021
@elasticmachine elasticmachine added Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:Docs Meta label for docs team labels Jul 15, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@jrodewig jrodewig requested a review from iverase July 15, 2021 17:44
@iverase
Copy link
Contributor

iverase commented Jul 16, 2021

I have a quick look and it is looking great. I would like to wait until next week to give further feedback as we are going to discuss about some rough edges. Hope that's ok.

@jrodewig
Copy link
Contributor Author

Sounds good. Thanks @iverase!

Comment on lines +52 to +53
Using object notation, you can pass a <<search-api-fields,`format`>> argument to
customize the format of returned date or geospatial values.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This removes some duplicated copy for the fields API/parameter and replaces it with an xref. This should make it easier to maintain the docs if we add/remove more format options in the future.

@jrodewig
Copy link
Contributor Author

@elasticmachine update branch

@jrodewig jrodewig added auto-backport-and-merge and removed auto-backport Automatically create backport pull requests when merged labels Aug 4, 2021
@jrodewig
Copy link
Contributor Author

jrodewig commented Aug 4, 2021

@elasticmachine update branch

@mark-vieira mark-vieira added auto-backport Automatically create backport pull requests when merged and removed auto-backport-and-merge labels Aug 4, 2021
Copy link
Contributor

@iverase iverase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you so much @jrodewig, documentation is looking great and I think we can. already push this version forward. Note that we are in the process to remove the feature flag so might want to do the same before pushing it.

@jrodewig
Copy link
Contributor Author

jrodewig commented Aug 5, 2021

Thanks @iverase!

we are in the process to remove the feature flag so might want to do the same before pushing it.

Thanks for letting me know. I'll wait until #76068 is merged before merging this PR.

@jrodewig
Copy link
Contributor Author

jrodewig commented Aug 5, 2021

@elasticmachine run elasticsearch-ci/bwc

@jrodewig
Copy link
Contributor Author

jrodewig commented Aug 5, 2021

@elasticmachine update branch

@jrodewig
Copy link
Contributor Author

jrodewig commented Aug 5, 2021

@elasticmachine update branch

@jrodewig jrodewig added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Aug 5, 2021
@elasticsearchmachine elasticsearchmachine merged commit 96c4ee3 into elastic:master Aug 5, 2021
elasticsearchmachine pushed a commit to elasticsearchmachine/elasticsearch that referenced this pull request Aug 5, 2021
* [DOCS] Document `_mvt` API

Documents the `_mvt` API endpoint added with elastic#73872.

Relates to elastic#75242.

* Reword

* Rename API

* Fix doc.url in JSON spec

* Reword

* Reword

* Add content type to JSON spec

* Edits

* Fix typo

* Reword

* Update docs after meeting

* Fix typos

* Fix `size` default

* Updates for elastic#75522

* Fixes

* Clean up JSON spec

* Fix extent tag

* [DOCS] Add `<field>` constraints

* Minor clarification

* Update for elastic#75697

* Reword

* Update for elastic#75621

* Reword default sort

* Update for elastic#75367

* Remove unneeded whitespace

* Add experimental admon and if flags

* [DOCS] Remove ifdefs

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
7.x

elasticsearchmachine added a commit that referenced this pull request Aug 5, 2021
* [DOCS] Document `_mvt` API

Documents the `_mvt` API endpoint added with #73872.

Relates to #75242.

* Reword

* Rename API

* Fix doc.url in JSON spec

* Reword

* Reword

* Add content type to JSON spec

* Edits

* Fix typo

* Reword

* Update docs after meeting

* Fix typos

* Fix `size` default

* Updates for #75522

* Fixes

* Clean up JSON spec

* Fix extent tag

* [DOCS] Add `<field>` constraints

* Minor clarification

* Update for #75697

* Reword

* Update for #75621

* Reword default sort

* Update for #75367

* Remove unneeded whitespace

* Add experimental admon and if flags

* [DOCS] Remove ifdefs

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@jrodewig jrodewig deleted the docs__vectortiles-api branch August 10, 2021 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Geo Indexing, search aggregations of geo points and shapes auto-backport Automatically create backport pull requests when merged auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) >docs General docs changes Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:Clients Meta label for clients team Team:Docs Meta label for docs team v7.15.0 v8.0.0-alpha2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOCS] Document vector tiles API
8 participants