Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PublishPlugin gradle configuration cache compliant #74828

Merged

Conversation

breskeby
Copy link
Contributor

@breskeby breskeby commented Jul 1, 2021

for using --configuration-cache we need to remove some usages of the mutable project instance

@breskeby breskeby self-assigned this Jul 1, 2021
@breskeby breskeby added :Delivery/Build Build or test infrastructure >enhancement Team:Delivery Meta label for Delivery team v7.15.0 v8.0.0 labels Jul 1, 2021
@breskeby breskeby marked this pull request as ready for review July 5, 2021 06:55
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

@breskeby breskeby added auto-backport Automatically create backport pull requests when merged auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) labels Jul 5, 2021
for using --configuration-cache we need to remove some usages of the mutable project instance
@breskeby breskeby force-pushed the fix-publish-for-config-cache branch from 1af0a63 to 70d7a86 Compare July 27, 2021 15:39
@elasticsearchmachine elasticsearchmachine merged commit 29c7a76 into elastic:master Jul 27, 2021
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
7.x Commit could not be cherrypicked due to conflicts

To backport manually run:
backport --pr 74828

breskeby added a commit to breskeby/elasticsearch that referenced this pull request Jul 28, 2021
* Make PublishPlugin gradle configuration cache compliant

for using --configuration-cache we need to remove some usages of the mutable project instance

* Polishing
breskeby added a commit that referenced this pull request Jul 28, 2021
)

* Make PublishPlugin gradle configuration cache compliant

for using --configuration-cache we need to remove some usages of the mutable project instance

* Polishing
ywangd pushed a commit to ywangd/elasticsearch that referenced this pull request Jul 30, 2021
* Make PublishPlugin gradle configuration cache compliant

for using --configuration-cache we need to remove some usages of the mutable project instance

* Polishing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Delivery/Build Build or test infrastructure >enhancement Team:Delivery Meta label for Delivery team v7.15.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants