Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rest Api Compatibility] Typed endpoints for search _count api #73958

Merged
merged 4 commits into from
Jun 14, 2021
Merged

[Rest Api Compatibility] Typed endpoints for search _count api #73958

merged 4 commits into from
Jun 14, 2021

Conversation

pgomulka
Copy link
Contributor

@pgomulka pgomulka commented Jun 9, 2021

retrofits typed endpoints removed in #42112

relates #51816
Please enter the commit message for your changes. Lines starting

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS and architecture that we support?
  • If you are submitting this code for a class then read our policy for that.

@pgomulka
[Rest Api Compatibility] Typed endpoints for search _count api
468a751 
retrofits typed endpoints removed in elastic#42112

relates elastic#51816
 Please enter the commit message for your changes. Lines starting
@pgomulka pgomulka added :Core/Infra/REST API REST infrastructure and utilities v8.0.0 labels Jun 9, 2021
@pgomulka pgomulka self-assigned this Jun 9, 2021
@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Jun 9, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

pgomulka
pgomulka commented Jun 14, 2021
View reviewed changes
server/src/test/java/org/elasticsearch/rest/action/search/RestCountActionTests.java Outdated
}
//todo is this a real scenario to use ?type instead of /index/type

// public void testTypeParameter() {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we really care about this?
is this a real scenario to use ?type instead of /index/type

romseygeek
romseygeek approved these changes Jun 14, 2021
View reviewed changes
Copy link
Contributor

@romseygeek romseygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pgomulka pgomulka merged commit 13e884b into elastic:master Jun 14, 2021
@pgomulka pgomulka mentioned this pull request Jun 15, 2021
Closed
66 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romseygeek romseygeek romseygeek approved these changes

@jakelandis jakelandis Awaiting requested review from jakelandis

@joegallo joegallo Awaiting requested review from joegallo

Assignees
No one assigned
Labels
:Core/Infra/REST API REST infrastructure and utilities >enhancement Team:Core/Infra Meta label for core/infra team v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pgomulka @elasticmachine @romseygeek @jakelandis